tests: zms: allow to build & run on real platforms #86363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
butok
commented
Feb 26, 2025
butok
commented
- Allows to build and run ZMS tests on real platforms.
- Enables ZMS tests designed for a flash-simulator only when built for qemu_x86 or native_sim targets.
- Allows to build and run ZMS tests on real platforms. - Enables ZMS tests designed for a flash-simulator only when built for qemu_x86 or native_sim targets. Signed-off-by: Andrej Butok <[email protected]>
de-nordic
reviewed
Feb 26, 2025
Comment on lines
+7
to
+14
| #if defined(CONFIG_BOARD_QEMU_X86) || defined(CONFIG_ARCH_POSIX) | ||
| /* | ||
| * This test is designed to be run using flash-simulator which provide | ||
| * Enable tests designed to be run using flash-simulator which provide | ||
| * functionality for flash property customization and emulating errors in | ||
| * flash operation in parallel to regular flash API. | ||
| * Test should be run on qemu_x86 or native_sim target. | ||
| */ | ||
|
|
||
| #if !defined(CONFIG_BOARD_QEMU_X86) && !defined(CONFIG_ARCH_POSIX) | ||
| #error "Run only on qemu_x86 or a posix architecture based target (for ex. native_sim)" | ||
| #define TEST_ZMS_SIMULATOR |
There was a problem hiding this comment.
Would it be possible to make this via this test specific Kconfig, making the TEST_ZMS_SIMULATOR as Kconfig that would default to true if CONFIG_BOARD_QEMU_X86 or CONFIG_ARCH_POSIX?
This way it should be possible to set the Kconfig TEST_ZMS_SIMULATOR via proj.conf or sample.yaml/test.yaml.
There was a problem hiding this comment.
Would it be possible to make this via this test specific Kconfig, making the TEST_ZMS_SIMULATOR as Kconfig that would default to true if CONFIG_BOARD_QEMU_X86 or CONFIG_ARCH_POSIX? This way it should be possible to set the Kconfig TEST_ZMS_SIMULATOR via proj.conf or sample.yaml/test.yaml.
OK, I will do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.