Skip to content

Conversation

@YehudaEi
Copy link
Contributor

This patch updates the modules/lvgl/CMakeLists.txt to include the lv_arclabel.c source file in the Zephyr build.

Without this change, the arclabel widget from LVGL was not compiled into Zephyr projects, making it unavailable for use. Adding this file ensures that arclabel functionality is included and usable.

Change:

  • Added ${LVGL_DIR}/src/widgets/arclabel/lv_arclabel.c to zephyr_library_sources.

@github-actions
Copy link

Hello @YehudaEi, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot zephyrbot added area: LVGL Light and Versatile Graphics Library Support size: XS A PR changing only a single line of code labels Oct 10, 2025
Copy link
Contributor

@faxe1008 faxe1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw this also while prepping for the 9.4 release but have not gotten around to it. Thank you for your PR. But the commit message needs adjusting. Use module instead of driver.

@YehudaEi
Copy link
Contributor Author

But the commit message needs adjusting. Use module instead of driver.

@faxe1008 Fixed.

@JarmouniA
Copy link
Contributor

Commit sign-off needs adjusting as well, Zephyr requires full legal name
https://docs.zephyrproject.org/latest/contribute/guidelines.html#dco-sign-off

@YehudaEi
Copy link
Contributor Author

Commit sign-off needs adjusting as well, Zephyr requires full legal name

@JarmouniA Fixed.

@JarmouniA
Copy link
Contributor

Compliance issue
commit author name (Yehuda E) needs to match one of the signed-off-by entries.

Add the lv_arclabel.c source file to modules/lvgl/CMakeLists.txt
so that the Arclabel widget is compiled and available in Zephyr projects.

Previously, the arclabel widget was not included, making it unusable.

Signed-off-by: Yehuda Eisenberg <[email protected]>
@YehudaEi
Copy link
Contributor Author

@JarmouniA Fixed.

@sonarqubecloud
Copy link

@henrikbrixandersen henrikbrixandersen merged commit b4cd1a2 into zephyrproject-rtos:main Oct 14, 2025
26 checks passed
@github-actions
Copy link

Hi @YehudaEi!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@YehudaEi YehudaEi deleted the fix-lvgl-arclabel branch October 14, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: LVGL Light and Versatile Graphics Library Support size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants