-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Add lv_arclabel.c to LVGL Zephyr build #97361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lv_arclabel.c to LVGL Zephyr build #97361
Conversation
|
Hello @YehudaEi, and thank you very much for your first pull request to the Zephyr project! |
d3795ba to
eaba089
Compare
faxe1008
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw this also while prepping for the 9.4 release but have not gotten around to it. Thank you for your PR. But the commit message needs adjusting. Use module instead of driver.
eaba089 to
1641123
Compare
@faxe1008 Fixed. |
|
Commit sign-off needs adjusting as well, Zephyr requires full legal name |
1641123 to
44b5d53
Compare
@JarmouniA Fixed. |
|
Compliance issue |
Add the lv_arclabel.c source file to modules/lvgl/CMakeLists.txt so that the Arclabel widget is compiled and available in Zephyr projects. Previously, the arclabel widget was not included, making it unusable. Signed-off-by: Yehuda Eisenberg <[email protected]>
44b5d53 to
2f1e0b2
Compare
|
@JarmouniA Fixed. |
|
|
Hi @YehudaEi! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |



This patch updates the
modules/lvgl/CMakeLists.txtto include thelv_arclabel.csource file in the Zephyr build.Without this change, the arclabel widget from LVGL was not compiled into Zephyr projects, making it unavailable for use. Adding this file ensures that arclabel functionality is included and usable.
Change:
${LVGL_DIR}/src/widgets/arclabel/lv_arclabel.ctozephyr_library_sources.