Skip to content

Conversation

@TonyHan11
Copy link
Contributor

Changes included in this PR:

  • update drivers/rtc/rtc_sam.c to support sama7d65
  • add rtc to the support list in sama7d65_curiosity.yaml
  • enable tests/drivers/rtc/rtc_api for sama7d65_curiosity

Tested with cases under tests/drivers/rtc on sama7d65_curiosity board.

@zephyrbot zephyrbot added platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) area: RTC Real Time Clock area: Boards/SoCs area: Tests Issues related to a particular existing or missing test labels Nov 24, 2025
@nandojve nandojve added this to the v4.4.0 milestone Nov 29, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_microchip DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Dec 1, 2025
@zephyrbot zephyrbot added the platform: Microchip MEC Microchip MEC Platform label Dec 1, 2025
Add the binding file for Microchip rtc G1 peripheral.
Update the rtc node in sama7d6.dtsi file.

Signed-off-by: Tony Han <[email protected]>
Move the contents in Kconfig.sam0 and Kconfig.sam to a new file named
Kconfig.mchp for adding support for more rtc controllers provided by
Microchip.
Update Kconfig accordingly.

Signed-off-by: Tony Han <[email protected]>
Add G1 RTC driver for Microchip RTC Peripherals.
rtc_mchp_g1.c copied from rtc_sam.c with some definitions of registers
updated register to work with the generated SoC DFPs.

Signed-off-by: Tony Han <[email protected]>
Add rtc to section 'supported' in sama7d65_curiosity.yaml and
sama7g54_ek.yaml files.

Signed-off-by: Tony Han <[email protected]>
Enable tests: tests/drivers/rtc/rtc_api.

Signed-off-by: Tony Han <[email protected]>
@github-actions github-actions bot removed manifest manifest-hal_microchip DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Dec 2, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

@TonyHan11
Copy link
Contributor Author

Add a new driver rtc-mchp-g1 instead of reusing rtc-sam.c according to zephyrproject-rtos/hal_microchip#46 (comment), no re-definitions for the registers needed now.

Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the PR title to describe what is changing and why? Its hard to follow why sam0 is going away and mchp_g1 seems to be duplicating a lot from the atmel_sam driver

CONFIG_RTC_ALARM=y
CONFIG_RTC_UPDATE=y
CONFIG_RTC_CALIBRATION=y
# CONFIG_SPIN_VALIDATE is not set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

* SPDX-License-Identifier: Apache-2.0
*/

#define DT_DRV_COMPAT microchip_rtc_g1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file unmodified other than the compat? If it is, the existing sam driver can be extended to support both compats, if not, append your copyright to the header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Boards/SoCs area: Devicetree Bindings area: RTC Real Time Clock area: Tests Issues related to a particular existing or missing test platform: Microchip MEC Microchip MEC Platform platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants