-
Notifications
You must be signed in to change notification settings - Fork 8.3k
driver: rtc: add RTC support for Microchip sama7d65_curiosity board #99889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0730239 to
21488d8
Compare
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Add the binding file for Microchip rtc G1 peripheral. Update the rtc node in sama7d6.dtsi file. Signed-off-by: Tony Han <[email protected]>
Move the contents in Kconfig.sam0 and Kconfig.sam to a new file named Kconfig.mchp for adding support for more rtc controllers provided by Microchip. Update Kconfig accordingly. Signed-off-by: Tony Han <[email protected]>
Add G1 RTC driver for Microchip RTC Peripherals. rtc_mchp_g1.c copied from rtc_sam.c with some definitions of registers updated register to work with the generated SoC DFPs. Signed-off-by: Tony Han <[email protected]>
Add rtc to section 'supported' in sama7d65_curiosity.yaml and sama7g54_ek.yaml files. Signed-off-by: Tony Han <[email protected]>
Enable tests: tests/drivers/rtc/rtc_api. Signed-off-by: Tony Han <[email protected]>
21488d8 to
584644e
Compare
|
|
Add a new driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the PR title to describe what is changing and why? Its hard to follow why sam0 is going away and mchp_g1 seems to be duplicating a lot from the atmel_sam driver
| CONFIG_RTC_ALARM=y | ||
| CONFIG_RTC_UPDATE=y | ||
| CONFIG_RTC_CALIBRATION=y | ||
| # CONFIG_SPIN_VALIDATE is not set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| #define DT_DRV_COMPAT microchip_rtc_g1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file unmodified other than the compat? If it is, the existing sam driver can be extended to support both compats, if not, append your copyright to the header



Changes included in this PR:
drivers/rtc/rtc_sam.cto support sama7d65rtcto the support list insama7d65_curiosity.yamltests/drivers/rtc/rtc_apifor sama7d65_curiosityTested with cases under
tests/drivers/rtcon sama7d65_curiosity board.