Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger levels #108

Open
zeratax opened this issue Dec 23, 2019 · 2 comments
Open

logger levels #108

zeratax opened this issue Dec 23, 2019 · 2 comments
Labels
question Further information is requested

Comments

@zeratax
Copy link
Owner

zeratax commented Dec 23, 2019

At some point this new logger is probably going to be commited, but I do wonder how much the current (I assume they won't change in @hadis1000 commits) log levels make sense, do we need more and should we change current logging statements?

I assume most of us either have the logger completely on or completely off, but it would be nice to make this as sensible as possible.

enum class loglevel {
  NONE,    /**< don't log at all */
  ERROR,   /**< an ERROR which should not be ignored */
  WARNING, /**< a WARNING which might be ignored */
  INFO,    /**< a INFO which can be ignored */
  DEBUG,   /**< verbose INFO which can be ignored */
  DEBUG1   /**< verbose DEBUG which can be ignored */
};
@zeratax zeratax added the question Further information is requested label Dec 23, 2019
@zeratax
Copy link
Owner Author

zeratax commented Dec 23, 2019

Also I think we now use neither warning nor error with #106

@visualJames
Copy link
Collaborator

With #109 will automatically a warning created, if error != NVRTC_SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants