Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exception shouldn't use logger #171

Open
zeratax opened this issue May 9, 2020 · 0 comments
Open

exception shouldn't use logger #171

zeratax opened this issue May 9, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@zeratax
Copy link
Owner

zeratax commented May 9, 2020

https://github.com/ZerataX/yacx/blob/master/include/yacx/Exception.hpp#L81
seems really weird to me to put the logger here?
any uncaught exception ends up on std:cerr anyways, no?

Also think https://github.com/ZerataX/yacx/blob/master/include/yacx/Exception.hpp#L115
the file and line should have the same format as the logger: [file:linenumber]

also feel like it shouldn't be called nvidiaException and more like yacx exception or something like that?

https://github.com/ZerataX/yacx/blob/master/src/Program.cpp#L63-L64

also think it's weird that we don't just log the log and instead use this exception specialty function

@zeratax zeratax added the bug Something isn't working label May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant