Merge pull request rapid7#19986 from sjanusz-r7/add-teamcity-login-scanner-test

Add TeamCity Login Scanner spec test

Author: jheysel-r7

lib/metasploit/framework/login_scanner/teamcity.rb

@@ -125,7 +125,9 @@ def encrypt_data(text, public_key)
         LIKELY_SERVICE_NAMES = [
           # Comes from nmap 7.95 on MacOS
           'skynetflow',
-          'teamcity'
+          'teamcity',
+          'http',
+          'https'
         ]
         PRIVATE_TYPES        = [:password]
         REALM_KEY            = nil

spec/modules/auxiliary/scanner/teamcity/teamcity_login_spec.rb

@@ -3,6 +3,10 @@
 
 RSpec.describe Metasploit::Framework::LoginScanner::TeamCity do
 
+  it_behaves_like 'Metasploit::Framework::LoginScanner::Base', has_realm_key: false, has_default_realm: false
+  it_behaves_like 'Metasploit::Framework::LoginScanner::RexSocket'
+  it_behaves_like 'Metasploit::Framework::LoginScanner::HTTP'
+
   let(:subject) { described_class.new }
 
   # Sample public key taken from a running instance of TeamCity