Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evmDeposit and evmDepositAndCall should quote Uniswap when reverting #77

Open
fadeev opened this issue Feb 17, 2025 · 0 comments
Open
Labels

Comments

@fadeev
Copy link
Member

fadeev commented Feb 17, 2025

Right now when onCall reverts, these functions swap the deposited amount for the ZRC-20 of the gas token to make a revert back to the connected chain. It's better to quote Uniswap first, and if the amount ends up insufficient, then abort.

I don't think it affects the flow, because if the deposited amount is insufficient, the swap would fail, so the amount would be correct.

But still quoting would be an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant