improve check for EnsureNoStaleBallots to ignore Pending Ballots

kingpinXD · kingpinXD · commit 2a44a8b772e0 · 2025-03-04T11:41:59.000-05:00
diff --git a/e2e/runner/require.go b/e2e/runner/require.go
@@ -74,6 +74,12 @@ func (r *E2ERunner) EnsureNoStaleBallots() {
 	if len(ballotsRes.Ballots) < 1 {
 		return
 	}
-	firstBallotCreationHeight := ballotsRes.Ballots[0].BallotCreationHeight
+	firstBallotCreationHeight := int64(0)
+
+	for _, ballot := range ballotsRes.Ballots {
+		if ballot.IsFinalized() {
+			firstBallotCreationHeight = ballot.BallotCreationHeight
+		}
+	}
 	require.GreaterOrEqual(r, firstBallotCreationHeight, staleBlockStart, "there should be no stale ballots")
 }

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,12 @@ func (r *E2ERunner) EnsureNoStaleBallots() {`
`74`	`74`	`if len(ballotsRes.Ballots) < 1 {`
`75`	`75`	`return`
`76`	`76`	`}`
`77`		`- firstBallotCreationHeight := ballotsRes.Ballots[0].BallotCreationHeight`
	`77`	`+ firstBallotCreationHeight := int64(0)`
	`78`	`+`
	`79`	`+ for _, ballot := range ballotsRes.Ballots {`
	`80`	`+ if ballot.IsFinalized() {`
	`81`	`+ firstBallotCreationHeight = ballot.BallotCreationHeight`
	`82`	`+ }`
	`83`	`+ }`
`78`	`84`	`require.GreaterOrEqual(r, firstBallotCreationHeight, staleBlockStart, "there should be no stale ballots")`
`79`	`85`	`}`