You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewers MUST merge the PR if there are no BLOCKERS
If I am analyzing someone else's (perhaps including an earlier instance of myself) code, and I complete that analysis without finding a reason that the code cannot merge into the consensus understanding of the "codebase" (aka dev), then I am obligated out of compassion and respect for the author, to add that code to the consensus.
2 Reviewers MUST create new issues to track non-BLOCKERS
3 Developers MUST NOT open a new PR before they complete the review of all PRs assigned to them
4 CI SHALL only run the "quick" profile on commit to a PR, reviewers MUST verify full tests against nightly OR local within 24 hours
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Reviewers MUST merge the PR if there are no BLOCKERS
If I am analyzing someone else's (perhaps including an earlier instance of myself) code, and I complete that analysis without finding a reason that the code cannot merge into the consensus understanding of the "codebase" (aka
dev), then I am obligated out of compassion and respect for the author, to add that code to the consensus.2 Reviewers MUST create new issues to track non-BLOCKERS
3 Developers MUST NOT open a new PR before they complete the review of all PRs assigned to them
4 CI SHALL only run the "quick" profile on commit to a PR, reviewers MUST verify full tests against nightly OR local within 24 hours
Beta Was this translation helpful? Give feedback.
All reactions