Consistently use Generator::isDefault() where appropriate (#1940) (#1941)

(cherry picked from commit 650fb4a)

Co-authored-by: Martin Rademacher <mano@radebatz.net>

Author: github-actions[bot]

docs/examples/processors/schema-query-parameter/SchemaQueryParameter.php

@@ -29,7 +29,7 @@ public function __invoke(Analysis $analysis): void
         $operations = $analysis->getAnnotationsOfType(Operation::class);
 
         foreach ($operations as $operation) {
-            if ($operation->x !== Generator::UNDEFINED && array_key_exists(self::REF, $operation->x)) {
+            if (!Generator::isDefault($operation->x) && array_key_exists(self::REF, $operation->x)) {
                 if (!is_string($operation->x[self::REF])) {
                     throw new \InvalidArgumentException('Value of `x.' . self::REF . '` must be a string');
                 }

src/Annotations/License.php

@@ -92,7 +92,7 @@ public function validate(array $stack = [], array $skip = [], string $ref = '',
         $valid = parent::validate($stack, $skip, $ref, $context);
 
         if (!$this->_context->isVersion('3.0.x')) {
-            if (!Generator::isDefault($this->url) && $this->identifier !== Generator::UNDEFINED) {
+            if (!Generator::isDefault($this->url) && !Generator::isDefault($this->identifier)) {
                 $this->_context->logger->warning($this->identity() . ' url and identifier are mutually exclusive');
                 $valid = false;
             }

src/Processors/Concerns/DocblockTrait.php

@@ -132,7 +132,7 @@ public function parseDocblock(?string $docblock, ?array &$tags = null): string
      */
     public function extractCommentSummary(string $content): string
     {
-        if ($content === Generator::UNDEFINED) {
+        if (Generator::isDefault($content)) {
             return Generator::UNDEFINED;
         }
 
@@ -159,12 +159,12 @@ public function extractCommentSummary(string $content): string
      */
     public function extractCommentDescription(string $content): string
     {
-        if ($content === Generator::UNDEFINED) {
+        if (Generator::isDefault($content)) {
             return Generator::UNDEFINED;
         }
 
         $summary = $this->extractCommentSummary($content);
-        if ($summary === Generator::UNDEFINED) {
+        if (Generator::isDefault($summary)) {
             return Generator::UNDEFINED;
         }
 
@@ -201,7 +201,7 @@ public function parseVarLine(?string $docblock): array
      */
     public function extractExampleDescription(string $docblock): ?string
     {
-        if (!$docblock || $docblock === Generator::UNDEFINED) {
+        if (!$docblock || Generator::isDefault($docblock)) {
             return null;
         }
 
@@ -215,7 +215,7 @@ public function extractExampleDescription(string $docblock): ?string
      */
     public function isDeprecated(?string $docblock): bool
     {
-        if (!$docblock || $docblock === Generator::UNDEFINED) {
+        if (!$docblock || Generator::isDefault($docblock)) {
             return false;
         }