Skip to content

Commit fe4209c

Browse files
committed
Fix explainxkcd extraction on 2408
1 parent ede76d8 commit fe4209c

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

Diff for: fastlane/metadata/android/en-US/changelogs/75.txt

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
- Fix compatibility with Android 12
2+
- Fix explainxkcd extraction on xkcd#2408
23

34
Full release note on https://is.gd/xkcd_app

Diff for: fastlane/metadata/android/zh-CN/changelogs/75.txt

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
- 修复与 Android 12 的兼容性
2+
- 修复 #2408 的 explainxkcd 提取
23

34
查看完整更新日志 https://is.gd/xkcd_app

Diff for: xkcd/src/main/java/xyz/jienan/xkcd/model/util/XkcdExplainUtil.kt

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ object XkcdExplainUtil {
1515
val doc = Jsoup.parse(responseBody.string())
1616
doc.setBaseUri(url)
1717

18-
val h2Explain = doc.selectFirst("h2:has(span#Explanation)")
18+
// https://explainxkcd.com/wiki/index.php/2408:_Egg_Strategies doesn't have Explanation span, good luck
19+
val h2Explain = doc.selectFirst("h2:has(span#Explanation)") ?: doc.selectFirst("h2")
1920
val nextH2Element = h2Explain.nextElementSiblings().select("h2").first()
2021

2122
val h2ExplainElementIndex = h2Explain.parent().childNodes().indexOf(h2Explain)

0 commit comments

Comments
 (0)