Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the preprocess interface for SkipperModule #9

Open
EasonLiao opened this issue Sep 25, 2014 · 0 comments
Open

Change the preprocess interface for SkipperModule #9

EasonLiao opened this issue Sep 25, 2014 · 0 comments

Comments

@EasonLiao
Copy link
Member

Currently the preprocess callback for SkipperModule is defined like this :

abstract ByteBuffer preprocess(ByteBuffer request);

In the preprocess callback of SkipperStateMachine, we first deserialize the ByteBuffer to command to see what types of command it is then pass ByteBuffer to preprocess of module. We should pass command directly because normally we'll deserialize the bytebuffer again in preprocess of module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant