review eslint core rules: enable some rules for parameters

Author: zloirock

packages/core-js-compat/compat.js

@@ -25,7 +25,7 @@ function getModules(filter) {
 
 function normalizeModules(option) {
   // TODO: use `.flatMap` in core-js@4
-  return new Set(Array.isArray(option) ? [].concat.apply([], option.map(getModules)) : getModules(option));
+  return new Set(Array.isArray(option) ? [].concat(...option.map(getModules)) : getModules(option));
 }
 
 function checkModule(name, targets) {

tests/eslint/eslint.config.js

@@ -124,6 +124,8 @@ const base = {
   camelcase: [ERROR, { properties: NEVER }],
   // enforce default clauses in switch statements to be last
   'default-case-last': ERROR,
+  // enforce default parameters to be last
+  'default-param-last': ERROR,
   // encourages use of dot notation whenever possible
   'dot-notation': [ERROR, { allowKeywords: true }],
   // require the use of === and !==
@@ -262,6 +264,10 @@ const base = {
   'prefer-exponentiation-operator': ERROR,
   // prefer `Object.hasOwn`
   'prefer-object-has-own': ERROR,
+  // require rest parameters instead of `arguments`
+  'prefer-rest-params': ERROR,
+  // require spread operators instead of `.apply()`
+  'prefer-spread': ERROR,
   // require template literals instead of string concatenation
   'prefer-template': ERROR,
   // require or disallow use of quotes around object literal property names
@@ -767,6 +773,10 @@ const es3 = {
   'prefer-exponentiation-operator': OFF,
   // prefer `Object.hasOwn`
   'prefer-object-has-own': OFF,
+  // require rest parameters instead of `arguments`
+  'prefer-rest-params': OFF,
+  // require spread operators instead of `.apply()`
+  'prefer-spread': OFF,
   // require template literals instead of string concatenation
   'prefer-template': OFF,
   // require or disallow use of quotes around object literal property names

tests/helpers/helpers.js

@@ -139,8 +139,8 @@ export function patchRegExp$exec(run) {
   return assert => {
     const originalExec = RegExp.prototype.exec;
     // eslint-disable-next-line no-extend-native -- required for testing
-    RegExp.prototype.exec = function () {
-      return originalExec.apply(this, arguments);
+    RegExp.prototype.exec = function (...args) {
+      return originalExec.apply(this, args);
     };
     try {
       return run(assert);

tests/helpers/qunit-helpers.js

@@ -33,7 +33,7 @@ assign(QUnit.assert, {
         : 'Enumerability is not applicable',
     });
   },
-  epsilon(a, b, EPSILON = 1e-11, message) {
+  epsilon(a, b, EPSILON = 1e-11, message = null) {
     const result = Math.abs(a - b) <= EPSILON;
     this.pushResult({
       result,

tests/unit-global/es.array.from.js

@@ -1,3 +1,4 @@
+/* eslint-disable prefer-rest-params -- required for testing */
 import { DESCRIPTORS, GLOBAL } from '../helpers/constants';
 import { createIterable } from '../helpers/helpers';
 

tests/unit-global/es.array.is-array.js

@@ -7,6 +7,7 @@ QUnit.test('Array.isArray', assert => {
   assert.nonEnumerable(Array, 'isArray');
   assert.false(isArray({}));
   assert.false(isArray(function () {
+    // eslint-disable-next-line prefer-rest-params -- required for testing
     return arguments;
   }()));
   assert.true(isArray([]));

tests/unit-global/es.object.to-string.js

@@ -20,6 +20,7 @@ QUnit.test('Object#toString', assert => {
   assert.same(toString.call(/./), '[object RegExp]', 'regexp -> `RegExp`');
   assert.same(toString.call(new TypeError()), '[object Error]', 'new TypeError -> `Error`');
   assert.same(toString.call(function () {
+    // eslint-disable-next-line prefer-rest-params -- required for testing
     return arguments;
   }()), '[object Arguments]', 'arguments -> `Arguments`');
   const constructors = [

tests/unit-global/es.regexp.test.js

@@ -1,8 +1,8 @@
 
 QUnit.test('RegExp#test delegates to exec', assert => {
-  const exec = function () {
+  const exec = function (...args) {
     execCalled = true;
-    return /./.exec.apply(this, arguments);
+    return /./.exec.apply(this, args);
   };
 
   let execCalled = false;

tests/unit-global/es.string.from-code-point.js

@@ -1,3 +1,4 @@
+/* eslint-disable prefer-spread -- required for testing */
 QUnit.test('String.fromCodePoint', assert => {
   const { fromCodePoint } = String;
   assert.isFunction(fromCodePoint);

tests/unit-global/es.string.match.js

@@ -228,9 +228,9 @@ QUnit.test('String#match delegates to @@match', assert => {
 });
 
 QUnit.test('RegExp#@@match delegates to exec', assert => {
-  const exec = function () {
+  const exec = function (...args) {
     execCalled = true;
-    return /./.exec.apply(this, arguments);
+    return /./.exec.apply(this, args);
   };
 
   let execCalled = false;