Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lessons fail to account for default user-agent margin on body #32

Open
faceless2 opened this issue Aug 3, 2023 · 2 comments
Open

lessons fail to account for default user-agent margin on body #32

faceless2 opened this issue Aug 3, 2023 · 2 comments
Assignees
@zopyx

Comments

@faceless2
Copy link

The default user-agent stylesheet as used by Firefox, Chrome, Safari and BFO Publisher sets body { margin: 8px }. Any tool that does this will see lesson-deer wrapping onto the second page because you have html, body { height: 100%} , and lesson-account-statement will not be able to fit your left and right-floating tables side-by-side. You need a body { margin: 0 } rule in both.

In lesson-deer, I'd also strongly suggest setting <!DOCTYPE html> at the top of the file, otherwise you're relying on how quirks-mode is implemented in whichever tool you're testing.
@zopyx zopyx self-assigned this Sep 16, 2023
@zopyx
Copy link
Owner

zopyx commented Sep 25, 2023

Possibly true. However, I did not find a simple case where this would make a difference for the tools tested.

@faceless2
Copy link
Author

faceless2 commented Sep 25, 2023 •
edited
Loading

I just listed two - your "lesson-deer" and "lesson-account-statement" examples

You can test it yourself on printcss.live. It should be easy to verify makes a difference; add body { margin: 8px} to your deer example and test in tools that don't have this as a rule (prince, etc) or - alternatively - set body { margin: 0} to the example and test in tools that do have this as a rule (ie BFO Publisher)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zopyx zopyx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zopyx @faceless2