Improve coroutine performance

Fixes #33
zorg2044 · Nov 16, 2024 · 1f4b847 · 1f4b847
1 parent 30e99bb
commit 1f4b847
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/Source/Modules/ModuleBCSAirbags.cs b/Source/Modules/ModuleBCSAirbags.cs
@@ -261,7 +261,7 @@ private void SetupPartIcon()
             }
         }
 
-            private void StopAltitudeCoroutine()
+        private void StopAltitudeCoroutine()
         {
             if (altitudeCoroutine != null)
             {
@@ -323,15 +323,15 @@ private void PlayAnimation(Animation anim, string animationName, float start, fl
         // Coroutines
         public IEnumerator AltitudeCoroutine()
         {
-            yield return new WaitUntil(ShouldDeploy);
+            while (!ShouldDeploy()) yield return new WaitForFixedUpdate();
             part.stackIcon.SetIconColor(XKCDColors.Yellow);
             if (nodeCoroutine == null) nodeCoroutine = StartCoroutine(NodeCoroutine());
         }
 
         public IEnumerator NodeCoroutine()
         {
             StopAltitudeCoroutine();
-            yield return new WaitUntil(NodeDetached);
+            while (!NodeDetached()) yield return new WaitForFixedUpdate();
 
             bool isAboveWater = vessel.terrainAltitude <= 0;
             if ((isAboveWater && !deployAboveWater) || (!isAboveWater && !deployAboveLand)) Disarm();

diff --git a/Source/Modules/ModuleDecoupleAtAltitude.cs b/Source/Modules/ModuleDecoupleAtAltitude.cs
@@ -106,7 +106,8 @@ protected bool ShouldJetison()
 
         public IEnumerator AltitudeDecouple()
         {
-            yield return new WaitUntil(ShouldJetison);
+            while (!ShouldJetison()) yield return new WaitForFixedUpdate();
+
             Decouple();
         }
     }