Skip to content

Commit f3cbb5e

Browse files
committed
WIP cleanups here and there
1 parent 68d7189 commit f3cbb5e

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

defaults/main.yml

+2-8
Original file line numberDiff line numberDiff line change
@@ -15,20 +15,14 @@ apache_vhosts:
1515
# apache_mods:
1616
# - name: rewrite
1717
# state: present
18-
apache_mods:
19-
- name: rewrite
20-
state: present
21-
- name: ssl
22-
state: present
18+
apache_mods: []
2319

2420
# Only used on Debian/Ubuntu.
2521
# Example:
2622
# apache_confs:
2723
# - name: trace
2824
# state: absent
29-
apache_confs:
30-
- name: trace
31-
state: absent
25+
apache_confs: []
3226

3327
# httpd.conf
3428
#

tasks/add-vhost.yml

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
_apache_vhost_ssl: "{{ _apache_vhost_ssl_item }}"
2121
loop: "{{ apache_vhost.ssl }}"
2222
loop_control:
23+
label: "{{ apache_vhost | to_vhost_filename }}"
2324
loop_var: _apache_vhost_ssl_item
2425
when:
2526
- apache_skip_vhost_on_missing_ssl_cert

tasks/configure-Debian.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@
2222
vars:
2323
apache_vhost: "{{ item }}"
2424
loop: "{{ apache_vhosts }}"
25+
# NOTE(zstyblik): cannot use to_vhost_filename until validated.
2526
loop_control:
26-
label: "{{ item | to_vhost_filename }}"
27+
label: "{{ item.servername | default('unknown') }}:{{ item.port | default(0) }}"
2728

2829
- name: Gather Binding to Addresses and Ports information.
2930
apache_ports_generator:
@@ -203,6 +204,8 @@
203204
vars:
204205
apache_vhost: "{{ item }}"
205206
loop: "{{ apache_vhosts }}"
207+
loop_control:
208+
label: "{{ item | to_vhost_filename }}"
206209

207210
# NOTE(zstyblik): run a2en* regardless
208211
# re-add check "is in a2q STDOUT", if necessary to save cycles.

0 commit comments

Comments
 (0)