msglist [nfc]: Simplify fetch-older check to extentAfter

gnprice · gnprice · commit 037fc7298a77 · 2024-01-29T16:58:40.000-08:00
This is a more readable way of expressing the exact same thing.
diff --git a/lib/widgets/message_list.dart b/lib/widgets/message_list.dart
@@ -218,8 +218,7 @@ class _MessageListState extends State<MessageList> with PerAccountStoreAwareStat
       _scrollToBottomVisibleValue.value = true;
     }
 
-    final extentRemainingAboveViewport = scrollMetrics.maxScrollExtent - scrollMetrics.pixels;
-    if (extentRemainingAboveViewport < kFetchMessagesBufferPixels) {
+    if (scrollMetrics.extentAfter < kFetchMessagesBufferPixels) {
       // TODO: This ends up firing a second time shortly after we fetch a batch.
       //   The result is that each time we decide to fetch a batch, we end up
       //   fetching two batches in quick succession.  This is basically harmless

Original file line number	Diff line number	Diff line change
`@@ -218,8 +218,7 @@ class _MessageListState extends State<MessageList> with PerAccountStoreAwareStat`
`218`	`218`	`_scrollToBottomVisibleValue.value = true;`
`219`	`219`	`}`
`220`	`220`
`221`		`- final extentRemainingAboveViewport = scrollMetrics.maxScrollExtent - scrollMetrics.pixels;`
`222`		`- if (extentRemainingAboveViewport < kFetchMessagesBufferPixels) {`
	`221`	`+ if (scrollMetrics.extentAfter < kFetchMessagesBufferPixels) {`
`223`	`222`	`// TODO: This ends up firing a second time shortly after we fetch a batch.`
`224`	`223`	`// The result is that each time we decide to fetch a batch, we end up`
`225`	`224`	`// fetching two batches in quick succession. This is basically harmless`