Skip to content

Commit 0933a26

Browse files
launch_url: Add i18n for launchUrl error messages
1 parent db90fdb commit 0933a26

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

assets/l10n/app_en.arb

+11
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,17 @@
308308
"@loginServerUrlInputLabel": {
309309
"description": "Input label in login page for Zulip server URL entry."
310310
},
311+
"errorUnableToOpenLinkTitle": "Unable to open link",
312+
"@errorUnableToOpenLinkTitle": {
313+
"description": "Error title when a link fails to open."
314+
},
315+
"errorUnableToOpenLinkMessage": "Link could not be opened: {url}",
316+
"@errorUnableToOpenLinkMessage": {
317+
"description": "Error message when a link fails to open.",
318+
"placeholders": {
319+
"url": {"type": "String", "example": "http://example.com/"}
320+
}
321+
},
311322
"loginHidePassword": "Hide password",
312323
"@loginHidePassword": {
313324
"description": "Icon label for button to hide password in input form."

lib/widgets/launch_url.dart

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import 'package:flutter/foundation.dart';
22
import 'package:flutter/material.dart';
33
import 'package:flutter/services.dart';
4+
import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
45

56
import '../model/binding.dart';
67
import '../model/internal_link.dart';
@@ -10,11 +11,12 @@ import 'store.dart';
1011

1112
/// Handles showing an error dialog with a customizable message.
1213
Future<void> _showError(BuildContext context, String? message, String urlString) {
14+
final zulipLocalizations = ZulipLocalizations.of(context);
1315
return showErrorDialog(
1416
context: context,
15-
title: 'Unable to open link',
17+
title: zulipLocalizations.errorUnableToOpenLinkTitle,
1618
message: [
17-
'Link could not be opened: $urlString',
19+
zulipLocalizations.errorUnableToOpenLinkMessage(urlString),
1820
if (message != null) message,
1921
].join("\n\n"));
2022
}

0 commit comments

Comments
 (0)