intl: Change some hard-coded strings to be localized

sirpengi · sirpengi · commit 0e2bf007e7b6 · 2023-09-11T22:35:21.000+01:00
Showcasing using full static strings in widgets, strings
with placeholders that need to respond to pluralization,
and strings in error dialogs.
diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
@@ -1 +1,60 @@
-{}
+{
+  "chooseAccountPageTitle": "Choose account",
+  "@chooseAccountPageTitle": {
+    "description": "Title for ChooseAccountPage"
+  },
+  "chooseAccountButtonAddAnAccount": "Add an account",
+  "@chooseAccountButtonAddAnAccount": {
+    "description": "Label for ChooseAccountPage button to add an account"
+  },
+  "profileButtonSendDirectMessage": "Send direct message",
+  "@profileButtonSendDirectMessage": {
+    "description": "Label for button in profile screen to navigate to DMs with the shown user."
+  },
+  "cameraAccessDeniedTitle": "Permissions needed",
+  "@cameraAccessDeniedTitle": {
+    "description": "Title for dialog when the user needs to grant permissions for camera access."
+  },
+  "cameraAccessDeniedMessage": "To upload an image, please grant Zulip additional permissions in Settings.",
+  "@cameraAccessDeniedMessage": {
+    "description": "Message for dialog when the user needs to grant permissions for camera access."
+  },
+  "cameraAccessDeniedButtonText": "Open settings",
+  "@cameraAccessDeniedButtonText": {
+    "description": "Message for dialog when the user needs to grant permissions for camera access."
+  },
+  "subscribedToNStreams": "Subscribed to {num, plural, =0{no streams} =1{1 stream} other{{num} streams}}",
+  "@subscribedToNStreams": {
+    "description": "Test page label showing number of streams user is subscribed to.",
+    "placeholders": {
+      "num": {
+        "type": "int",
+        "example": "4"
+      }
+    }
+  },
+  "userRoleOwner": "Owner",
+  "@userRoleOwner": {
+    "description": "Label for UserRole.owner"
+  },
+  "userRoleAdministrator": "Administrator",
+  "@userRoleAdministrator": {
+    "description": "Label for UserRole.administrator"
+  },
+  "userRoleModerator": "Moderator",
+  "@userRoleModerator": {
+    "description": "Label for UserRole.moderator"
+  },
+  "userRoleMember": "Member",
+  "@userRoleMember": {
+    "description": "Label for UserRole.member"
+  },
+  "userRoleGuest": "Guest",
+  "@userRoleGuest": {
+    "description": "Label for UserRole.guest"
+  },
+  "userRoleUnknown": "Unknown",
+  "@userRoleUnknown": {
+    "description": "Label for UserRole.unknown"
+  }
+}
diff --git a/assets/l10n/app_ja.arb b/assets/l10n/app_ja.arb
@@ -1 +1,15 @@
-{}
+{
+  "chooseAccountPageTitle": "アカウントを選択",
+  "chooseAccountButtonAddAnAccount": "新しいアカウントを追加",
+  "profileButtonSendDirectMessage": "ダイレクトメッセージを送信",
+  "cameraAccessDeniedTitle": "権限が必要です",
+  "cameraAccessDeniedMessage": "画像をアップロードするには、「設定」で Zulip に追加の権限を許可してください。",
+  "cameraAccessDeniedButtonText": "設定を開く",
+  "subscribedToNStreams": "{num, plural, other{{num}つのストリームをフォローしています}}",
+  "userRoleOwner": "オーナー",
+  "userRoleAdministrator": "管理者",
+  "userRoleModerator": "モデレータ",
+  "userRoleMember": "メンバー",
+  "userRoleGuest": "ゲスト",
+  "userRoleUnknown": "不明"
+}
diff --git a/lib/widgets/app.dart b/lib/widgets/app.dart
@@ -79,11 +79,12 @@ class ChooseAccountPage extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
+    final zulipLocalizations = ZulipLocalizations.of(context);
     assert(!PerAccountStoreWidget.debugExistsOf(context));
     final globalStore = GlobalStoreWidget.of(context);
     return Scaffold(
       appBar: AppBar(
-        title: const Text('Choose account'),
+        title: Text(zulipLocalizations.chooseAccountPageTitle),
         actions: const [ChooseAccountPageOverflowButton()]),
       body: SafeArea(
         minimum: const EdgeInsets.all(8),
@@ -100,7 +101,7 @@ class ChooseAccountPage extends StatelessWidget {
               ElevatedButton(
                 onPressed: () => Navigator.push(context,
                   AddAccountPage.buildRoute()),
-                child: const Text('Add an account')),
+                child: Text(zulipLocalizations.chooseAccountButtonAddAnAccount)),
             ]))),
       ));
   }
@@ -140,6 +141,7 @@ class HomePage extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     final store = PerAccountStoreWidget.of(context);
+    final zulipLocalizations = ZulipLocalizations.of(context);
 
     InlineSpan bold(String text) => TextSpan(
       text: text, style: const TextStyle(fontWeight: FontWeight.bold));
@@ -164,10 +166,7 @@ class HomePage extends StatelessWidget {
               Text.rich(TextSpan(
                 text: 'Zulip server version: ',
                 children: [bold(store.zulipVersion)])),
-              Text.rich(TextSpan(text: 'Subscribed to ', children: [
-                bold(store.subscriptions.length.toString()),
-                const TextSpan(text: ' streams'),
-              ])),
+              Text(zulipLocalizations.subscribedToNStreams(store.subscriptions.length)),
             ])),
           const SizedBox(height: 16),
           ElevatedButton(
diff --git a/lib/widgets/compose_box.dart b/lib/widgets/compose_box.dart
@@ -2,6 +2,7 @@ import 'package:app_settings/app_settings.dart';
 import 'package:file_picker/file_picker.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
+import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
 import 'package:image_picker/image_picker.dart';
 
 import '../api/model/model.dart';
@@ -603,6 +604,7 @@ class _AttachFromCameraButton extends _AttachUploadsButton {
 
   @override
   Future<Iterable<_File>> getFiles(BuildContext context) async {
+    final zulipLocalizations = ZulipLocalizations.of(context);
     final picker = ImagePicker();
     final XFile? result;
     try {
@@ -619,10 +621,10 @@ class _AttachFromCameraButton extends _AttachUploadsButton {
         // permission-request alert once, the first time the app wants to
         // use a protected resource. After that, the only way the user can
         // grant it is in Settings.
-        showSuggestedActionDialog(context: context, // TODO(i18n)
-          title: 'Permissions needed',
-          message: 'To upload an image, please grant Zulip additional permissions in Settings.',
-          actionButtonText: 'Open settings',
+        showSuggestedActionDialog(context: context,
+          title: zulipLocalizations.cameraAccessDeniedTitle,
+          message: zulipLocalizations.cameraAccessDeniedMessage,
+          actionButtonText: zulipLocalizations.cameraAccessDeniedButtonText,
           onActionButtonPress: () {
             AppSettings.openAppSettings();
           });
diff --git a/lib/widgets/profile.dart b/lib/widgets/profile.dart
@@ -1,6 +1,7 @@
 import 'dart:convert';
 
 import 'package:flutter/material.dart';
+import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
 
 import '../api/model/model.dart';
 import '../model/content.dart';
@@ -28,6 +29,7 @@ class ProfilePage extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
+    final zulipLocalizations = ZulipLocalizations.of(context);
     final store = PerAccountStoreWidget.of(context);
     final user = store.users[userId];
     if (user == null) {
@@ -42,7 +44,7 @@ class ProfilePage extends StatelessWidget {
         textAlign: TextAlign.center,
         style: _TextStyles.primaryFieldText.merge(const TextStyle(fontWeight: FontWeight.bold))),
       // TODO(#291) render email field
-      Text(roleToLabel(user.role),
+      Text(roleToLabel(user.role, zulipLocalizations),
         textAlign: TextAlign.center,
         style: _TextStyles.primaryFieldText),
       // TODO(#197) render user status
@@ -56,7 +58,7 @@ class ProfilePage extends StatelessWidget {
           MessageListPage.buildRoute(context: context,
             narrow: DmNarrow.withUser(userId, selfUserId: store.account.userId))),
         icon: const Icon(Icons.email),
-        label: const Text('Send direct message')),
+        label: Text(zulipLocalizations.profileButtonSendDirectMessage)),
     ];
 
     return Scaffold(
@@ -93,14 +95,14 @@ class _ProfileErrorPage extends StatelessWidget {
   }
 }
 
-String roleToLabel(UserRole role) {
+String roleToLabel(UserRole role, ZulipLocalizations zulipLocalizations) {
   return switch (role) {
-    UserRole.owner => 'Owner',
-    UserRole.administrator => 'Administrator',
-    UserRole.moderator => 'Moderator',
-    UserRole.member => 'Member',
-    UserRole.guest => 'Guest',
-    UserRole.unknown => 'Unknown',
+    UserRole.owner => zulipLocalizations.userRoleOwner,
+    UserRole.administrator => zulipLocalizations.userRoleAdministrator,
+    UserRole.moderator => zulipLocalizations.userRoleModerator,
+    UserRole.member => zulipLocalizations.userRoleMember,
+    UserRole.guest => zulipLocalizations.userRoleGuest,
+    UserRole.unknown => zulipLocalizations.userRoleUnknown,
   };
 }
 
diff --git a/test/widgets/profile_test.dart b/test/widgets/profile_test.dart
@@ -1,6 +1,7 @@
 import 'package:checks/checks.dart';
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
+import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:url_launcher/url_launcher.dart';
 import 'package:zulip/api/model/initial_snapshot.dart';
@@ -44,6 +45,8 @@ Future<void> setupPage(WidgetTester tester, {
     GlobalStoreWidget(
       child: MaterialApp(
         navigatorObservers: navigatorObserver != null ? [navigatorObserver] : [],
+        localizationsDelegates: ZulipLocalizations.localizationsDelegates,
+        supportedLocales: ZulipLocalizations.supportedLocales,
         home: PerAccountStoreWidget(
           accountId: eg.selfAccount.id,
           child: ProfilePage(userId: pageUserId)))));
