Skip to content

Commit 10d0fe8

Browse files
chrisbobbegnprice
authored andcommitted
ui: Adjust app bar and scaffold-background to align with new Figma design
From discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20colors/near/1801938 and the Figma linked there: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=2074%3A26325&t=rjuqcQaHMiGBUReF-1 Now, the app-bar bottom border is colored by the new Figma's `border-bar`, and the main background color is `bg-main`. The app bar background is unchanged because it already matches `bg-top-bar`. I've labeled these values with comments in the code. And all these color variables have dark-theme variants! (See discussion for what those are.) That'll help when we implement dark theme, #95.
1 parent b9e585e commit 10d0fe8

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

lib/widgets/theme.dart

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,12 @@ ThemeData zulipThemeData(BuildContext context) {
1212
// ColorScheme.surfaceContainer for the scrolled-under state and
1313
// ColorScheme.surface otherwise, and those are different colors.
1414
scrolledUnderElevation: 0,
15-
backgroundColor: Color(0xfff5f5f5),
15+
backgroundColor: Color(0xfff5f5f5), // `bg-top-bar` in Figma
1616

17-
shape: Border(bottom: BorderSide(color: Color(0xffcccccc))),
17+
shape: Border(bottom: BorderSide(
18+
color: Color(0x33000000), // `border-bar` in Figma
19+
strokeAlign: BorderSide.strokeAlignInside, // (default restated for explicitness)
20+
)),
1821
),
1922
// This applies Material 3's color system to produce a palette of
2023
// appropriately matching and contrasting colors for use in a UI.
@@ -27,7 +30,7 @@ ThemeData zulipThemeData(BuildContext context) {
2730
colorScheme: ColorScheme.fromSeed(
2831
seedColor: kZulipBrandColor,
2932
),
30-
scaffoldBackgroundColor: const Color(0xfff6f6f6),
33+
scaffoldBackgroundColor: const Color(0xfff0f0f0), // `bg-main` in Figma
3134
tooltipTheme: const TooltipThemeData(preferBelow: false),
3235
);
3336
}

0 commit comments

Comments
 (0)