Skip to content

Commit 247bf7f

Browse files
committed
store test [nfc]: Clarify what prepareReload is doing
1 parent dd9b29b commit 247bf7f

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

test/example_data.dart

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -964,9 +964,14 @@ PerAccountStore store({
964964
}
965965
const _store = store;
966966

967-
UpdateMachine updateMachine({Account? account, InitialSnapshot? initialSnapshot}) {
967+
UpdateMachine updateMachine({
968+
GlobalStore? globalStore,
969+
Account? account,
970+
InitialSnapshot? initialSnapshot,
971+
}) {
968972
initialSnapshot ??= _initialSnapshot();
969-
final store = _store(account: account, initialSnapshot: initialSnapshot);
973+
final store = _store(globalStore: globalStore,
974+
account: account, initialSnapshot: initialSnapshot);
970975
return UpdateMachine.fromInitialSnapshot(
971976
store: store, initialSnapshot: initialSnapshot);
972977
}

test/model/store_test.dart

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -972,16 +972,20 @@ void main() {
972972

973973
Future<void> prepareReload(FakeAsync async) async {
974974
globalStore = LoadingTestGlobalStore(accounts: [eg.selfAccount]);
975+
976+
// Simulate the setup that [TestGlobalStore.doLoadPerAccount] would do.
977+
// (These tests use [LoadingTestGlobalStore] for greater control in
978+
// later steps; that requires this setup step to be finer-grained too.)
979+
final updateMachine = eg.updateMachine(
980+
globalStore: globalStore, account: eg.selfAccount);
981+
final store = updateMachine.store;
975982
final future = globalStore.perAccount(eg.selfAccount.id);
976-
final store = eg.store(globalStore: globalStore, account: eg.selfAccount);
977983
completers().single.complete(store);
978984
await future;
979985
completers().clear();
980-
final updateMachine = UpdateMachine.fromInitialSnapshot(
981-
store: store, initialSnapshot: eg.initialSnapshot());
986+
982987
updateMachine.debugPauseLoop();
983988
updateMachine.poll();
984-
985989
(store.connection as FakeApiConnection).prepare(
986990
apiException: eg.apiExceptionBadEventQueueId());
987991
updateMachine.debugAdvanceLoop();

0 commit comments

Comments
 (0)