Skip to content

Commit 49253cc

Browse files
committed
msglist test: Remove redundant regression test.
A test on CombinedFeedNarrow is sufficient for preventing this particular regression. We could go further and test this on other narrows that do not have a compose box (at the time CombinedFeedNarrow was the only narrow without it), but there is little to gain other than verifying that the same fix applies to those narrows as well, assuming that we also add a check to confirm that the compose box is absent. Signed-off-by: Zixuan James Li <[email protected]>
1 parent c5598d7 commit 49253cc

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

test/widgets/message_list_test.dart

-13
Original file line numberDiff line numberDiff line change
@@ -135,19 +135,6 @@ void main() {
135135
final padding = MediaQuery.of(element).padding;
136136
check(padding).equals(EdgeInsets.zero);
137137
});
138-
139-
testWidgets('content in MentionsNarrow not asked to consume insets (including bottom)', (tester) async {
140-
const fakePadding = FakeViewPadding(left: 10, top: 10, right: 10, bottom: 10);
141-
tester.view.viewInsets = fakePadding;
142-
tester.view.padding = fakePadding;
143-
144-
await setupMessageListPage(tester, narrow: const MentionsNarrow(),
145-
messages: [eg.streamMessage(content: ContentExample.codeBlockPlain.html, flags: [MessageFlag.mentioned])]);
146-
147-
final element = tester.element(find.byType(CodeBlock));
148-
final padding = MediaQuery.of(element).padding;
149-
check(padding).equals(EdgeInsets.zero);
150-
});
151138
});
152139

153140
testWidgets('smoke test for light/dark/lerped', (tester) async {

0 commit comments

Comments
 (0)