Skip to content

Commit 5f8917a

Browse files
committed
autocomplete [nfc]: Move down MentionAutocompleteView.computeResults
This will result in a more logical order of the class members.
1 parent c392ae1 commit 5f8917a

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

lib/model/autocomplete.dart

+17-17
Original file line numberDiff line numberDiff line change
@@ -439,23 +439,6 @@ class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery,
439439
final Narrow narrow;
440440
final List<User> sortedUsers;
441441

442-
@override
443-
Future<List<MentionAutocompleteResult>?> computeResults() async {
444-
final results = <MentionAutocompleteResult>[];
445-
if (await filterCandidates(filter: _testUser,
446-
candidates: sortedUsers, results: results)) {
447-
return null;
448-
}
449-
return results;
450-
}
451-
452-
MentionAutocompleteResult? _testUser(MentionAutocompleteQuery query, User user) {
453-
if (query.testUser(user, store.autocompleteViewManager.autocompleteDataCache)) {
454-
return UserMentionAutocompleteResult(userId: user.userId);
455-
}
456-
return null;
457-
}
458-
459442
static List<User> _usersByRelevance({
460443
required PerAccountStore store,
461444
required Narrow narrow,
@@ -615,6 +598,23 @@ class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery,
615598
return userAName.compareTo(userBName); // TODO(i18n): add locale-aware sorting
616599
}
617600

601+
@override
602+
Future<List<MentionAutocompleteResult>?> computeResults() async {
603+
final results = <MentionAutocompleteResult>[];
604+
if (await filterCandidates(filter: _testUser,
605+
candidates: sortedUsers, results: results)) {
606+
return null;
607+
}
608+
return results;
609+
}
610+
611+
MentionAutocompleteResult? _testUser(MentionAutocompleteQuery query, User user) {
612+
if (query.testUser(user, store.autocompleteViewManager.autocompleteDataCache)) {
613+
return UserMentionAutocompleteResult(userId: user.userId);
614+
}
615+
return null;
616+
}
617+
618618
@override
619619
void dispose() {
620620
store.autocompleteViewManager.unregisterMentionAutocomplete(this);

0 commit comments

Comments
 (0)