Skip to content

Commit 6166a0a

Browse files
committed
dialog [nfc]: Inline _materialDialogActionTest in _adaptiveAction
As suggested at: #1017 (comment)
1 parent f365734 commit 6166a0a

File tree

1 file changed

+15
-17
lines changed

1 file changed

+15
-17
lines changed

lib/widgets/dialog.dart

+15-17
Original file line numberDiff line numberDiff line change
@@ -3,31 +3,29 @@ import 'package:flutter/material.dart';
33
import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
44
import 'package:flutter/foundation.dart';
55

6-
Widget _materialDialogActionText(String text) {
7-
return Text(
8-
text,
9-
10-
// As suggested by
11-
// https://api.flutter.dev/flutter/material/AlertDialog/actions.html :
12-
// > It is recommended to set the Text.textAlign to TextAlign.end
13-
// > for the Text within the TextButton, so that buttons whose
14-
// > labels wrap to an extra line align with the overall
15-
// > OverflowBar's alignment within the dialog.
16-
textAlign: TextAlign.end,
17-
);
18-
}
19-
206
/// A platform-appropriate action for [AlertDialog.adaptive]'s [actions] param.
217
Widget _adaptiveAction({required VoidCallback onPressed, required String text}) {
228
switch (defaultTargetPlatform) {
239
case TargetPlatform.android:
2410
case TargetPlatform.fuchsia:
2511
case TargetPlatform.linux:
2612
case TargetPlatform.windows:
27-
return TextButton(onPressed: onPressed, child: _materialDialogActionText(text));
13+
return TextButton(
14+
onPressed: onPressed,
15+
child: Text(
16+
text,
17+
// As suggested by
18+
// https://api.flutter.dev/flutter/material/AlertDialog/actions.html :
19+
// > It is recommended to set the Text.textAlign to TextAlign.end
20+
// > for the Text within the TextButton, so that buttons whose
21+
// > labels wrap to an extra line align with the overall
22+
// > OverflowBar's alignment within the dialog.
23+
textAlign: TextAlign.end));
2824
case TargetPlatform.iOS:
2925
case TargetPlatform.macOS:
30-
return CupertinoDialogAction(onPressed: onPressed, child: Text(text));
26+
return CupertinoDialogAction(
27+
onPressed: onPressed,
28+
child: Text(text));
3129
}
3230
}
3331

@@ -90,4 +88,4 @@ void showSuggestedActionDialog({
9088
onPressed: onActionButtonPress,
9189
text: actionButtonText ?? zulipLocalizations.dialogContinue),
9290
]));
93-
}
91+
}

0 commit comments

Comments
 (0)