internal_links: Add Variable realmUrlWithSlash to add '/'

satyam372 · satyam372 · commit 74b44f3c68b5 · 2024-09-16T02:04:26.000+05:30
Updates the URL construction to include a trailing slash before the fragment identifier. This ensures that the URL is properly formatted and makes the url linkified. Fixes: #845
diff --git a/lib/model/internal_link.dart b/lib/model/internal_link.dart
@@ -96,7 +96,11 @@ Uri narrowLink(PerAccountStore store, Narrow narrow, {int? nearMessageId}) {
     fragment.write('/near/$nearMessageId');
   }
 
-  return store.realmUrl.replace(fragment: fragment.toString());
+  final realmUrlWithSlash = store.realmUrl.path.endsWith('/')
+      ? store.realmUrl
+      : store.realmUrl.replace(path: '${store.realmUrl.path}/');
+
+  return realmUrlWithSlash.replace(fragment: fragment.toString());
 }
 
 /// A [Narrow] from a given URL, on `store`'s realm.

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,11 @@ Uri narrowLink(PerAccountStore store, Narrow narrow, {int? nearMessageId}) {`
`96`	`96`	`fragment.write('/near/$nearMessageId');`
`97`	`97`	`}`
`98`	`98`
`99`		`- return store.realmUrl.replace(fragment: fragment.toString());`
	`99`	`+ final realmUrlWithSlash = store.realmUrl.path.endsWith('/')`
	`100`	`+ ? store.realmUrl`
	`101`	`+ : store.realmUrl.replace(path: '${store.realmUrl.path}/');`
	`102`	`+`
	`103`	`+ return realmUrlWithSlash.replace(fragment: fragment.toString());`
`100`	`104`	`}`
`101`	`105`
`102`	`106`	/// A [Narrow] from a given URL, on `store`'s realm.