Skip to content

Commit 863ae86

Browse files
committed
Remove unknown UserTopicVisibilityPolicy handling
1 parent ac6d1bd commit 863ae86

File tree

3 files changed

+2
-12
lines changed

3 files changed

+2
-12
lines changed

lib/model/channel.dart

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -128,17 +128,14 @@ mixin ChannelStore on UserStore {
128128
UserTopicVisibilityEffect willChangeIfTopicVisibleInStream(UserTopicEvent event) {
129129
final streamId = event.streamId;
130130
final topic = event.topicName;
131-
132131
final UserTopicVisibilityPolicy? visibilityPolicy = event.visibilityPolicy;
133132
if (ChannelStore._warnInvalidVisibilityPolicy(visibilityPolicy)) {
134133
return UserTopicVisibilityEffect.none;
135134
}
136-
137135
final UserTopicVisibilityPolicy policy = visibilityPolicy!;
138-
139136
return UserTopicVisibilityEffect._fromBeforeAfter(
140137
_isTopicVisibleInStream(topicVisibilityPolicy(streamId, topic)),
141-
_isTopicVisibleInStream(policy),);
138+
_isTopicVisibleInStream(policy));
142139
}
143140

144141
static bool _isTopicVisibleInStream(UserTopicVisibilityPolicy policy) {
@@ -170,17 +167,14 @@ mixin ChannelStore on UserStore {
170167
UserTopicVisibilityEffect willChangeIfTopicVisible(UserTopicEvent event) {
171168
final streamId = event.streamId;
172169
final topic = event.topicName;
173-
174170
final UserTopicVisibilityPolicy? visibilityPolicy = event.visibilityPolicy;
175171
if (ChannelStore._warnInvalidVisibilityPolicy(visibilityPolicy)) {
176172
return UserTopicVisibilityEffect.none;
177173
}
178-
179174
final UserTopicVisibilityPolicy policy = visibilityPolicy!;
180-
181175
return UserTopicVisibilityEffect._fromBeforeAfter(
182176
_isTopicVisible(streamId, topicVisibilityPolicy(streamId, topic)),
183-
_isTopicVisible(streamId, policy),);
177+
_isTopicVisible(streamId, policy));
184178
}
185179

186180
bool _isTopicVisible(int streamId, UserTopicVisibilityPolicy policy) {
@@ -584,9 +578,7 @@ class ChannelStoreImpl extends HasUserStore with ChannelStore {
584578
}
585579
return;
586580
}
587-
588581
final UserTopicVisibilityPolicy policy = visibilityPolicy!;
589-
590582
if (policy == UserTopicVisibilityPolicy.none) {
591583
final forStream = topicVisibility[event.streamId];
592584
if (forStream == null) return;

test/api/route/channels_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ void main() {
6060
});
6161

6262

63-
6463
test('updateUserTopicCompat when FL >= 170', () {
6564
return FakeApiConnection.with_((connection) async {
6665
connection.prepare(json: {});

test/model/channel_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,6 @@ void main() {
516516
await store.setUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted);
517517
// case-insensitivity
518518
await store.setUserTopic(stream1, 'ToPiC', null);
519-
520519
compareTopicVisibility(store, [
521520
]);
522521
});

0 commit comments

Comments
 (0)