msglist [nfc]: Add showSender flag, always true for now

Author: gnprice

lib/model/message_list.dart

@@ -29,9 +29,15 @@ class MessageListRecipientHeaderItem extends MessageListItem {
 class MessageListMessageItem extends MessageListItem {
   final Message message;
   ZulipContent content;
+  bool showSender;
   bool isLastInBlock;
 
-  MessageListMessageItem(this.message, this.content, {required this.isLastInBlock});
+  MessageListMessageItem(
+    this.message,
+    this.content, {
+    required this.showSender,
+    required this.isLastInBlock,
+  });
 }
 
 /// Indicates the app is loading more messages at the top.
@@ -183,7 +189,7 @@ mixin _MessageSequence {
     } else {
       items.add(MessageListRecipientHeaderItem(message));
     }
-    items.add(MessageListMessageItem(message, content, isLastInBlock: true));
+    items.add(MessageListMessageItem(message, content, showSender: true, isLastInBlock: true));
   }
 
   /// Update [items] to include markers at start and end as appropriate.

lib/widgets/message_list.dart

@@ -580,25 +580,30 @@ class MessageWithPossibleSender extends StatelessWidget {
       child: Padding(
         padding: const EdgeInsets.only(top: 2, bottom: 3, left: 8, right: 8),
         child: Row(crossAxisAlignment: CrossAxisAlignment.start, children: [
-          Padding(
-            padding: const EdgeInsets.fromLTRB(3, 6, 11, 0),
-            child: GestureDetector(
-              onTap: () => Navigator.push(context,
-                ProfilePage.buildRoute(context: context,
-                  userId: message.senderId)),
-              child: Avatar(userId: message.senderId, size: 35, borderRadius: 4))),
+          item.showSender
+            ? Padding(
+                padding: const EdgeInsets.fromLTRB(3, 6, 11, 0),
+                child: GestureDetector(
+                  onTap: () => Navigator.push(context,
+                    ProfilePage.buildRoute(context: context,
+                      userId: message.senderId)),
+                  child: Avatar(size: 35, borderRadius: 4,
+                    userId: message.senderId)))
+            : const SizedBox(width: 3 + 35 + 11),
           Expanded(
             child: Column(
               crossAxisAlignment: CrossAxisAlignment.stretch,
               children: [
-                const SizedBox(height: 3),
-                GestureDetector(
-                  onTap: () => Navigator.push(context,
-                    ProfilePage.buildRoute(context: context,
-                      userId: message.senderId)),
-                  child: Text(message.senderFullName, // TODO get from user data
-                    style: const TextStyle(fontWeight: FontWeight.bold))),
-                const SizedBox(height: 4),
+                if (item.showSender) ...[
+                  const SizedBox(height: 3),
+                  GestureDetector(
+                    onTap: () => Navigator.push(context,
+                      ProfilePage.buildRoute(context: context,
+                        userId: message.senderId)),
+                    child: Text(message.senderFullName, // TODO get from user data
+                      style: const TextStyle(fontWeight: FontWeight.bold))),
+                  const SizedBox(height: 4),
+                ],
                 MessageContent(message: message, content: item.content),
               ])),
           Container(

test/model/message_list_test.dart

@@ -677,6 +677,7 @@ void checkInvariants(MessageListView model) {
     check(model.items[i++]).isA<MessageListMessageItem>()
       ..message.identicalTo(model.messages[j])
       ..content.identicalTo(model.contents[j])
+      ..showSender.isTrue()
       ..isLastInBlock.equals(
         i == model.items.length || model.items[i] is! MessageListMessageItem);
   }
@@ -690,6 +691,7 @@ extension MessageListRecipientHeaderItemChecks on Subject<MessageListRecipientHe
 extension MessageListMessageItemChecks on Subject<MessageListMessageItem> {
   Subject<Message> get message => has((x) => x.message, 'message');
   Subject<ZulipContent> get content => has((x) => x.content, 'content');
+  Subject<bool> get showSender => has((x) => x.showSender, 'showSender');
   Subject<bool> get isLastInBlock => has((x) => x.isLastInBlock, 'isLastInBlock');
 }