Skip to content

Commit 8d2d06f

Browse files
gnpricechrisbobbe
authored andcommitted
autocomplete [nfc]: Group comparison/sorting methods together
These two methods were in between compareByRecency and compareByDms, which are closely-related siblings to each other. So move them outside that group.
1 parent 737ccb8 commit 8d2d06f

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

lib/model/autocomplete.dart

+13-13
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,19 @@ class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery,
311311
final Narrow narrow;
312312
final List<User> sortedUsers;
313313

314+
@override
315+
Iterable<User> getSortedItemsToTest() {
316+
return sortedUsers;
317+
}
318+
319+
@override
320+
MentionAutocompleteResult? testItem(MentionAutocompleteQuery query, User item) {
321+
if (query.testUser(item, store.autocompleteViewManager.autocompleteDataCache)) {
322+
return UserMentionAutocompleteResult(userId: item.userId);
323+
}
324+
return null;
325+
}
326+
314327
static List<User> _usersByRelevance({
315328
required PerAccountStore store,
316329
required Narrow narrow,
@@ -417,19 +430,6 @@ class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery,
417430
streamId: streamId, senderId: userB.userId));
418431
}
419432

420-
@override
421-
Iterable<User> getSortedItemsToTest() {
422-
return sortedUsers;
423-
}
424-
425-
@override
426-
MentionAutocompleteResult? testItem(MentionAutocompleteQuery query, User item) {
427-
if (query.testUser(item, store.autocompleteViewManager.autocompleteDataCache)) {
428-
return UserMentionAutocompleteResult(userId: item.userId);
429-
}
430-
return null;
431-
}
432-
433433
/// Determines which of the two users is more recent in DM conversations.
434434
///
435435
/// Returns a negative number if [userA] is more recent than [userB],

0 commit comments

Comments
 (0)