Skip to content

Commit 9b4f796

Browse files
rajveermalviyagnprice
authored andcommitted
android build: Avoid specifying ndkVersion explicitly
Specifying the NDK version here doesn't seem to do us any good. This value provided by the `flutter` tool is currently 23.1.7779620. If we upgrade the Android Gradle plugin (AGP) to 8.5.2, its current latest, then we start getting build warnings: #879 (comment) saying that a bunch of plugins -- including first-party plugins -- are all using NDK 26.1.10909125 instead, and telling us to switch to that. Conversely, if we leave this line out, then the same AGP upgrade causes no warnings and works just fine. So let the version float. This does contradict AGP's own recommendation: https://developer.android.com/studio/projects/configure-agp-ndk which is to use this `ndkVersion` property. But if a bunch of our plugins are going to use a floating version anyway, it doesn't seem helpful to try to hang back. [greg: added commit-message body]
1 parent baed78b commit 9b4f796

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

android/app/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ android {
2323
namespace "com.zulip.flutter"
2424

2525
compileSdkVersion flutter.compileSdkVersion
26-
ndkVersion flutter.ndkVersion
2726

2827
compileOptions {
2928
sourceCompatibility JavaVersion.VERSION_1_8

0 commit comments

Comments
 (0)