Skip to content

Commit 9bdd810

Browse files
committed
store [nfc]: Update outdated references to loadGlobalStore
These were supposed to be updated in commit fc80be1 where we replaced loadGlobalStore with getGlobalStore. `LiveGlobalBindings.load` is the only thing left analogous to the previously referred to `loadGlobalStore` method. To avoid direct referencce to this specific implementation on `GlobalStore`, mention that loading it for the first time is expected to be asynchronous instead. Signed-off-by: Zixuan James Li <[email protected]>
1 parent d81c65a commit 9bdd810

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/model/binding.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ abstract class ZulipBinding {
7676
}
7777

7878
/// Get the app's singleton [GlobalStore],
79-
/// calling [loadGlobalStore] if not already loaded.
79+
/// loading it asynchronously if not already loaded.
8080
///
8181
/// Where possible, use [GlobalStoreWidget.of] to get access to a [GlobalStore].
8282
/// Use this method only in contexts like notifications where
@@ -312,7 +312,7 @@ class PackageInfo {
312312

313313
/// A concrete binding for use in the live application.
314314
///
315-
/// The global store returned by [loadGlobalStore], and consequently by
315+
/// The global store returned by [getGlobalStore], and consequently by
316316
/// [GlobalStoreWidget.of] in application code, will be a [LiveGlobalStore].
317317
/// It therefore uses a live server and live, persistent local database.
318318
///

test/model/binding.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ TestZulipBinding get testBinding => TestZulipBinding.instance;
3030
/// and [TestGlobalStore.add] to set up test data there. Such test functions
3131
/// must also call [reset] to clean up the global store.
3232
///
33-
/// The global store returned by [loadGlobalStore], and consequently by
33+
/// The global store returned by [getGlobalStore], and consequently by
3434
/// [GlobalStoreWidget.of] in application code, will be a [TestGlobalStore].
3535
class TestZulipBinding extends ZulipBinding {
3636
/// Initialize the binding if necessary, and ensure it is a [TestZulipBinding].

0 commit comments

Comments
 (0)