compose: Translate "(loading message {messageId})"

and implement the necessary plumbing to access ZulipLocalizations

Signed-off-by: Zixuan James Li <[email protected]>

Author: PIG208

assets/l10n/app_en.arb

@@ -351,6 +351,13 @@
       "filename": {"type": "String", "example": "file.txt"}
     }
   },
+  "composeBoxLoadingMessage": "(loading message {messageId})",
+  "@composeBoxLoadingMessage": {
+    "description": "Placeholder in compose box showing the quoted message is currently loading.",
+    "placeholders": {
+      "messageId": {"type": "int", "example": "1234"}
+    }
+  },
   "unknownUserName": "(unknown user)",
   "@unknownUserName": {
     "description": "Name placeholder to use for a user when we don't know their name."

lib/generated/l10n/zulip_localizations.dart

@@ -567,6 +567,12 @@ abstract class ZulipLocalizations {
   /// **'Uploading {filename}…'**
   String composeBoxUploadingFilename(String filename);
 
+  /// Placeholder in compose box showing the quoted message is currently loading.
+  ///
+  /// In en, this message translates to:
+  /// **'(loading message {messageId})'**
+  String composeBoxLoadingMessage(int messageId);
+
   /// Name placeholder to use for a user when we don't know their name.
   ///
   /// In en, this message translates to:

lib/generated/l10n/zulip_localizations_ar.dart

@@ -277,6 +277,11 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
     return 'Uploading $filename…';
   }
 
+  @override
+  String composeBoxLoadingMessage(int messageId) {
+    return '(loading message $messageId)';
+  }
+
   @override
   String get unknownUserName => '(unknown user)';
 

lib/generated/l10n/zulip_localizations_en.dart

@@ -277,6 +277,11 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
     return 'Uploading $filename…';
   }
 
+  @override
+  String composeBoxLoadingMessage(int messageId) {
+    return '(loading message $messageId)';
+  }
+
   @override
   String get unknownUserName => '(unknown user)';
 

lib/generated/l10n/zulip_localizations_ja.dart

@@ -277,6 +277,11 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
     return 'Uploading $filename…';
   }
 
+  @override
+  String composeBoxLoadingMessage(int messageId) {
+    return '(loading message $messageId)';
+  }
+
   @override
   String get unknownUserName => '(unknown user)';
 

lib/generated/l10n/zulip_localizations_nb.dart

@@ -277,6 +277,11 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
     return 'Uploading $filename…';
   }
 
+  @override
+  String composeBoxLoadingMessage(int messageId) {
+    return '(loading message $messageId)';
+  }
+
   @override
   String get unknownUserName => '(unknown user)';
 

lib/generated/l10n/zulip_localizations_pl.dart

@@ -277,6 +277,11 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
     return 'Przekazywanie $filename…';
   }
 
+  @override
+  String composeBoxLoadingMessage(int messageId) {
+    return '(loading message $messageId)';
+  }
+
   @override
   String get unknownUserName => '(nieznany użytkownik)';
 

lib/generated/l10n/zulip_localizations_ru.dart

@@ -277,6 +277,11 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
     return 'Загрузка $filename…';
   }
 
+  @override
+  String composeBoxLoadingMessage(int messageId) {
+    return '(loading message $messageId)';
+  }
+
   @override
   String get unknownUserName => '(неизвестный пользователь)';
 

lib/generated/l10n/zulip_localizations_sk.dart

@@ -277,6 +277,11 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
     return 'Uploading $filename…';
   }
 
+  @override
+  String composeBoxLoadingMessage(int messageId) {
+    return '(loading message $messageId)';
+  }
+
   @override
   String get unknownUserName => '(unknown user)';
 

lib/model/compose.dart

@@ -1,6 +1,7 @@
 import 'dart:math';
 
 import '../api/model/model.dart';
+import '../generated/l10n/zulip_localizations.dart';
 import 'internal_link.dart';
 import 'narrow.dart';
 import 'store.dart';
@@ -136,7 +137,9 @@ String inlineLink(String visibleText, Uri? destination) {
 }
 
 /// What we show while fetching the target message's raw Markdown.
-String quoteAndReplyPlaceholder(PerAccountStore store, {
+String quoteAndReplyPlaceholder(
+  ZulipLocalizations zulipLocalizations,
+  PerAccountStore store, {
   required Message message,
 }) {
   final sender = store.users[message.senderId];
@@ -146,7 +149,7 @@ String quoteAndReplyPlaceholder(PerAccountStore store, {
     nearMessageId: message.id);
   // See note in [quoteAndReply] about asking `mention` to omit the |<id> part.
   return '${mention(sender!, silent: true)} ${inlineLink('said', url)}: ' // TODO(#1285)
-    '*(loading message ${message.id})*\n'; // TODO(i18n) ?
+    '*${zulipLocalizations.composeBoxLoadingMessage(message.id)}*\n';
 }
 
 /// Quote-and-reply syntax.

lib/widgets/action_sheet.dart

@@ -665,7 +665,9 @@ class QuoteAndReplyButton extends MessageActionSheetMenuItemButton {
     // This inserts a "[Quoting…]" placeholder into the content input,
     // giving the user a form of progress feedback.
     final tag = composeBoxController.content
-      .registerQuoteAndReplyStart(PerAccountStoreWidget.of(pageContext),
+      .registerQuoteAndReplyStart(
+        zulipLocalizations,
+        PerAccountStoreWidget.of(pageContext),
         message: message,
       );
 

lib/widgets/compose_box.dart

@@ -213,10 +213,15 @@ class ComposeContentController extends ComposeController<ContentValidationError>
   ///
   /// Returns an int "tag" that should be passed to registerQuoteAndReplyEnd on
   /// success or failure
-  int registerQuoteAndReplyStart(PerAccountStore store, {required Message message}) {
+  int registerQuoteAndReplyStart(
+    ZulipLocalizations zulipLocalizations,
+    PerAccountStore store, {
+      required Message message,
+    }) {
     final tag = _nextQuoteAndReplyTag;
     _nextQuoteAndReplyTag += 1;
-    final placeholder = quoteAndReplyPlaceholder(store, message: message);
+    final placeholder = quoteAndReplyPlaceholder(
+      zulipLocalizations, store, message: message);
     _quoteAndReplies[tag] = (messageId: message.id, placeholder: placeholder);
     notifyListeners(); // _quoteAndReplies change could affect validationErrors
     insertPadded(placeholder);

test/model/compose_test.dart

@@ -1,6 +1,7 @@
 import 'package:checks/checks.dart';
 import 'package:test/scaffolding.dart';
 import 'package:zulip/model/compose.dart';
+import 'package:zulip/model/localizations.dart';
 
 import '../example_data.dart' as eg;
 import 'test_store.dart';
@@ -260,7 +261,8 @@ hello
     await store.addStream(stream);
     await store.addUser(sender);
 
-    check(quoteAndReplyPlaceholder(store, message: message)).equals('''
+    check(quoteAndReplyPlaceholder(
+      GlobalLocalizations.zulipLocalizations, store, message: message)).equals('''
 @_**Full Name|123** [said](${eg.selfAccount.realmUrl}#narrow/stream/1-test-here/topic/some.20topic/near/${message.id}): *(loading message ${message.id})*
 ''');
 

test/widgets/action_sheet_test.dart

@@ -641,7 +641,8 @@ void main() {
       }) {
         check(contentController).value.equals((ComposeContentController()
           ..value = valueBefore
-          ..insertPadded(quoteAndReplyPlaceholder(store, message: message))
+          ..insertPadded(quoteAndReplyPlaceholder(
+              GlobalLocalizations.zulipLocalizations, store, message: message))
         ).value);
         check(contentController).validationErrors.contains(ContentValidationError.quoteAndReplyInProgress);
       }