Skip to content

Commit b715ce3

Browse files
launch_url: Add i18n for launchUrl error messages
- Utilize i18n for consistent error messaging.
1 parent 5cc5dff commit b715ce3

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

assets/l10n/app_en.arb

+11
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,17 @@
289289
"@loginServerUrlInputLabel": {
290290
"description": "Input label in login page for Zulip server URL entry."
291291
},
292+
"errorUnableToOpenLinkTitle": "Unable to open link",
293+
"@errorUnableToOpenLinkTitle": {
294+
"description": "Error title when a link fails to open."
295+
},
296+
"errorLinkCouldNotBeOpened": "Link could not be opened: {url}",
297+
"@errorLinkCouldNotBeOpened": {
298+
"description": "Error message when a specific link could not be opened.",
299+
"placeholders": {
300+
"url": {"type": "String", "example": "http://example.com/"}
301+
}
302+
},
292303
"loginHidePassword": "Hide password",
293304
"@loginHidePassword": {
294305
"description": "Icon label for button to hide password in input form."

lib/widgets/launch_url.dart

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import 'package:flutter/foundation.dart';
22
import 'package:flutter/material.dart';
33
import 'package:flutter/services.dart';
4+
import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
45

56
import '../model/binding.dart';
67
import '../model/internal_link.dart';
@@ -12,9 +13,9 @@ import 'store.dart';
1213
Future<void> _showError(BuildContext context, String? message, String urlString) {
1314
return showErrorDialog(
1415
context: context,
15-
title: 'Unable to open link',
16+
title: ZulipLocalizations.of(context).errorUnableToOpenLinkTitle,
1617
message: [
17-
'Link could not be opened: $urlString',
18+
ZulipLocalizations.of(context).errorLinkCouldNotBeOpened(urlString),
1819
if (message != null) message,
1920
].join("\n\n"));
2021
}

0 commit comments

Comments
 (0)