dialog: Add "Learn more"-button param to showErrorDialog

Author: chrisbobbe

Diff for: assets/l10n/app_en.arb

@@ -447,6 +447,10 @@
   "@dialogClose": {
     "description": "Button label in dialogs to close."
   },
+  "errorDialogLearnMore": "Learn more",
+  "@errorDialogLearnMore": {
+    "description": "Button label in error dialogs to open a web page with more information."
+  },
   "errorDialogContinue": "OK",
   "@errorDialogContinue": {
     "description": "Button label in error dialogs to acknowledge the error and close the dialog."

Diff for: lib/generated/l10n/zulip_localizations.dart

@@ -693,6 +693,12 @@ abstract class ZulipLocalizations {
   /// **'Close'**
   String get dialogClose;
 
+  /// Button label in error dialogs to open a web page with more information.
+  ///
+  /// In en, this message translates to:
+  /// **'Learn more'**
+  String get errorDialogLearnMore;
+
   /// Button label in error dialogs to acknowledge the error and close the dialog.
   ///
   /// In en, this message translates to:

Diff for: lib/generated/l10n/zulip_localizations_ar.dart

@@ -348,6 +348,9 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
   @override
   String get dialogClose => 'Close';
 
+  @override
+  String get errorDialogLearnMore => 'Learn more';
+
   @override
   String get errorDialogContinue => 'OK';
 

Diff for: lib/generated/l10n/zulip_localizations_en.dart

@@ -348,6 +348,9 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
   @override
   String get dialogClose => 'Close';
 
+  @override
+  String get errorDialogLearnMore => 'Learn more';
+
   @override
   String get errorDialogContinue => 'OK';
 

Diff for: lib/generated/l10n/zulip_localizations_ja.dart

@@ -348,6 +348,9 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
   @override
   String get dialogClose => 'Close';
 
+  @override
+  String get errorDialogLearnMore => 'Learn more';
+
   @override
   String get errorDialogContinue => 'OK';
 

Diff for: lib/generated/l10n/zulip_localizations_nb.dart

@@ -348,6 +348,9 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
   @override
   String get dialogClose => 'Close';
 
+  @override
+  String get errorDialogLearnMore => 'Learn more';
+
   @override
   String get errorDialogContinue => 'OK';
 

Diff for: lib/generated/l10n/zulip_localizations_pl.dart

@@ -348,6 +348,9 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
   @override
   String get dialogClose => 'Zamknij';
 
+  @override
+  String get errorDialogLearnMore => 'Learn more';
+
   @override
   String get errorDialogContinue => 'OK';
 

Diff for: lib/generated/l10n/zulip_localizations_ru.dart

@@ -348,6 +348,9 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
   @override
   String get dialogClose => 'Закрыть';
 
+  @override
+  String get errorDialogLearnMore => 'Learn more';
+
   @override
   String get errorDialogContinue => 'OK';
 

Diff for: lib/generated/l10n/zulip_localizations_sk.dart

@@ -348,6 +348,9 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
   @override
   String get dialogClose => 'Zavrieť';
 
+  @override
+  String get errorDialogLearnMore => 'Learn more';
+
   @override
   String get errorDialogContinue => 'OK';
 

Diff for: lib/widgets/dialog.dart

@@ -1,6 +1,7 @@
 import 'package:flutter/material.dart';
 
 import '../generated/l10n/zulip_localizations.dart';
+import 'actions.dart';
 
 Widget _dialogActionText(String text) {
   return Text(
@@ -27,7 +28,8 @@ class DialogStatus {
   final Future<void> closed;
 }
 
-/// Displays an [AlertDialog] with a dismiss button.
+/// Displays an [AlertDialog] with a dismiss button
+/// and optional "Learn more" button.
 ///
 /// The [DialogStatus.closed] field of the return value can be used
 /// for waiting for the dialog to be closed.
@@ -39,6 +41,7 @@ DialogStatus showErrorDialog({
   required BuildContext context,
   required String title,
   String? message,
+  Uri? learnMoreButtonUrl,
 }) {
   final zulipLocalizations = ZulipLocalizations.of(context);
   final future = showDialog<void>(
@@ -47,6 +50,10 @@ DialogStatus showErrorDialog({
       title: Text(title),
       content: message != null ? SingleChildScrollView(child: Text(message)) : null,
       actions: [
+        if (learnMoreButtonUrl != null)
+          TextButton(
+            onPressed: () => PlatformActions.launchUrl(context, learnMoreButtonUrl),
+            child: _dialogActionText(zulipLocalizations.errorDialogLearnMore)),
         TextButton(
           onPressed: () => Navigator.pop(context),
           child: _dialogActionText(zulipLocalizations.errorDialogContinue)),

Diff for: test/widgets/dialog_checks.dart

@@ -23,6 +23,8 @@ Widget checkErrorDialog(WidgetTester tester, {
       of: find.byWidget(dialog.content!), matching: find.text(expectedMessage)));
   }
 
+  // TODO check "Learn more" button?
+
   return tester.widget(
     find.descendant(of: find.byWidget(dialog),
       matching: find.widgetWithText(TextButton, 'OK')));

Diff for: test/widgets/dialog_test.dart

@@ -0,0 +1,29 @@
+import 'package:checks/checks.dart';
+import 'package:flutter/widgets.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:url_launcher/url_launcher.dart';
+import 'package:zulip/widgets/dialog.dart';
+
+import '../model/binding.dart';
+import 'test_app.dart';
+
+void main() {
+  TestZulipBinding.ensureInitialized();
+
+  group('showErrorDialog', () {
+    testWidgets('tap "Learn more" button', (tester) async {
+      addTearDown(testBinding.reset);
+      await tester.pumpWidget(TestZulipApp());
+      await tester.pump();
+      final element = tester.element(find.byType(Placeholder));
+
+      showErrorDialog(context: element, title: 'hello',
+        learnMoreButtonUrl: Uri.parse('foo.example'));
+      await tester.pump();
+      await tester.tap(find.text('Learn more'));
+      check(testBinding.takeLaunchUrlCalls()).single.equals((
+        url: Uri.parse('foo.example'),
+        mode: LaunchMode.platformDefault));
+    });
+  });
+}