wip; Current TODOs

PIG208 · PIG208 · commit e91e9d5d4d96 · 2024-12-16T19:28:19.000-05:00
Also need tests for the global store change.

And UI for updating the settings.

Signed-off-by: Zixuan James Li &lt;zixuan@zulip.com&gt;
diff --git a/lib/model/database.dart b/lib/model/database.dart
@@ -78,8 +78,10 @@ enum BrowserPreference {
 /// install of the app on this device).
 @DataClassName('GlobalSettingsData')
 class GlobalSettings extends Table {
+  // TODO(db): Maybe make this optional and/or use clientDefault?
   Column<String> get themeSetting => textEnum<ThemeSetting>()();
 
+  // TODO(db): Maybe make this optional and/or use clientDefault?
   Column<String> get browserPreference => textEnum<BrowserPreference>()();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -78,8 +78,10 @@ enum BrowserPreference {`
`78`	`78`	`/// install of the app on this device).`
`79`	`79`	`@DataClassName('GlobalSettingsData')`
`80`	`80`	`class GlobalSettings extends Table {`
	`81`	`+ // TODO(db): Maybe make this optional and/or use clientDefault?`
`81`	`82`	`Column<String> get themeSetting => textEnum<ThemeSetting>()();`
`82`	`83`
	`84`	`+ // TODO(db): Maybe make this optional and/or use clientDefault?`
`83`	`85`	`Column<String> get browserPreference => textEnum<BrowserPreference>()();`
`84`	`86`	`}`
`85`	`87`