Skip to content

Commit eb7a678

Browse files
rajveermalviyarajveermalviya
committed
notif: Fix error message when account not found in store
1 parent deaf23a commit eb7a678

13 files changed

+16
-24
lines changed

‎assets/l10n/app_en.arb

+3-3
Original file line numberDiff line numberDiff line change
@@ -835,9 +835,9 @@
835835
"@errorNotificationOpenTitle": {
836836
"description": "Error title when notification opening fails"
837837
},
838-
"errorNotificationOpenAccountMissing": "The account associated with this notification no longer exists.",
839-
"@errorNotificationOpenAccountMissing": {
840-
"description": "Error message when the account associated with the notification is not found"
838+
"errorNotificationOpenAccountLoggedOut": "The account associated with this notification was logged out.",
839+
"@errorNotificationOpenAccountLoggedOut": {
840+
"description": "Error message when the account associated with the notification is not logged in"
841841
},
842842
"errorReactionAddingFailedTitle": "Adding reaction failed",
843843
"@errorReactionAddingFailedTitle": {

‎assets/l10n/app_pl.arb

-4
Original file line numberDiff line numberDiff line change
@@ -557,10 +557,6 @@
557557
"@errorNotificationOpenTitle": {
558558
"description": "Error title when notification opening fails"
559559
},
560-
"errorNotificationOpenAccountMissing": "Konto związane z tym powiadomieniem już nie istnieje.",
561-
"@errorNotificationOpenAccountMissing": {
562-
"description": "Error message when the account associated with the notification is not found"
563-
},
564560
"aboutPageOpenSourceLicenses": "Licencje otwartego źródła",
565561
"@aboutPageOpenSourceLicenses": {
566562
"description": "Item title in About Zulip page to navigate to Licenses page"

‎assets/l10n/app_ru.arb

-4
Original file line numberDiff line numberDiff line change
@@ -287,10 +287,6 @@
287287
"@errorNotificationOpenTitle": {
288288
"description": "Error title when notification opening fails"
289289
},
290-
"errorNotificationOpenAccountMissing": "Учетной записи, связанной с этим оповещением, больше нет.",
291-
"@errorNotificationOpenAccountMissing": {
292-
"description": "Error message when the account associated with the notification is not found"
293-
},
294290
"switchAccountButton": "Сменить учетную запись",
295291
"@switchAccountButton": {
296292
"description": "Label for main-menu button leading to the choose-account page."

‎lib/generated/l10n/zulip_localizations.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -1221,11 +1221,11 @@ abstract class ZulipLocalizations {
12211221
/// **'Failed to open notification'**
12221222
String get errorNotificationOpenTitle;
12231223

1224-
/// Error message when the account associated with the notification is not found
1224+
/// Error message when the account associated with the notification is not logged in
12251225
///
12261226
/// In en, this message translates to:
1227-
/// **'The account associated with this notification no longer exists.'**
1228-
String get errorNotificationOpenAccountMissing;
1227+
/// **'The account associated with this notification was logged out.'**
1228+
String get errorNotificationOpenAccountLoggedOut;
12291229

12301230
/// Error title when adding a message reaction fails
12311231
///

‎lib/generated/l10n/zulip_localizations_ar.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
653653
String get errorNotificationOpenTitle => 'Failed to open notification';
654654

655655
@override
656-
String get errorNotificationOpenAccountMissing => 'The account associated with this notification no longer exists.';
656+
String get errorNotificationOpenAccountLoggedOut => 'The account associated with this notification was logged out.';
657657

658658
@override
659659
String get errorReactionAddingFailedTitle => 'Adding reaction failed';

‎lib/generated/l10n/zulip_localizations_en.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,7 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
653653
String get errorNotificationOpenTitle => 'Failed to open notification';
654654

655655
@override
656-
String get errorNotificationOpenAccountMissing => 'The account associated with this notification no longer exists.';
656+
String get errorNotificationOpenAccountLoggedOut => 'The account associated with this notification was logged out.';
657657

658658
@override
659659
String get errorReactionAddingFailedTitle => 'Adding reaction failed';

‎lib/generated/l10n/zulip_localizations_ja.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,7 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
653653
String get errorNotificationOpenTitle => 'Failed to open notification';
654654

655655
@override
656-
String get errorNotificationOpenAccountMissing => 'The account associated with this notification no longer exists.';
656+
String get errorNotificationOpenAccountLoggedOut => 'The account associated with this notification was logged out.';
657657

658658
@override
659659
String get errorReactionAddingFailedTitle => 'Adding reaction failed';

‎lib/generated/l10n/zulip_localizations_nb.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,7 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
653653
String get errorNotificationOpenTitle => 'Failed to open notification';
654654

655655
@override
656-
String get errorNotificationOpenAccountMissing => 'The account associated with this notification no longer exists.';
656+
String get errorNotificationOpenAccountLoggedOut => 'The account associated with this notification was logged out.';
657657

658658
@override
659659
String get errorReactionAddingFailedTitle => 'Adding reaction failed';

‎lib/generated/l10n/zulip_localizations_pl.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,7 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
653653
String get errorNotificationOpenTitle => 'Otwieranie powiadomienia bez powodzenia';
654654

655655
@override
656-
String get errorNotificationOpenAccountMissing => 'Konto związane z tym powiadomieniem już nie istnieje.';
656+
String get errorNotificationOpenAccountLoggedOut => 'The account associated with this notification was logged out.';
657657

658658
@override
659659
String get errorReactionAddingFailedTitle => 'Dodanie reakcji bez powodzenia';

‎lib/generated/l10n/zulip_localizations_ru.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,7 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
653653
String get errorNotificationOpenTitle => 'Не удалось открыть оповещения';
654654

655655
@override
656-
String get errorNotificationOpenAccountMissing => 'Учетной записи, связанной с этим оповещением, больше нет.';
656+
String get errorNotificationOpenAccountLoggedOut => 'The account associated with this notification was logged out.';
657657

658658
@override
659659
String get errorReactionAddingFailedTitle => 'Не удалось добавить реакцию';

‎lib/generated/l10n/zulip_localizations_sk.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,7 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
653653
String get errorNotificationOpenTitle => 'Nepodarilo sa otvoriť oznámenie';
654654

655655
@override
656-
String get errorNotificationOpenAccountMissing => 'The account associated with this notification no longer exists.';
656+
String get errorNotificationOpenAccountLoggedOut => 'The account associated with this notification was logged out.';
657657

658658
@override
659659
String get errorReactionAddingFailedTitle => 'Nepodarilo sa pridať reakciu';

‎lib/notifications/display.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@ class NotificationDisplayManager {
477477
final zulipLocalizations = ZulipLocalizations.of(context);
478478
showErrorDialog(context: context,
479479
title: zulipLocalizations.errorNotificationOpenTitle,
480-
message: zulipLocalizations.errorNotificationOpenAccountMissing);
480+
message: zulipLocalizations.errorNotificationOpenAccountLoggedOut);
481481
return null;
482482
}
483483

‎test/notifications/display_test.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -1059,7 +1059,7 @@ void main() {
10591059
check(pushedRoutes.single).isA<DialogRoute<void>>();
10601060
await tester.tap(find.byWidget(checkErrorDialog(tester,
10611061
expectedTitle: zulipLocalizations.errorNotificationOpenTitle,
1062-
expectedMessage: zulipLocalizations.errorNotificationOpenAccountMissing)));
1062+
expectedMessage: zulipLocalizations.errorNotificationOpenAccountLoggedOut)));
10631063
});
10641064

10651065
testWidgets('mismatching account', (tester) async {
@@ -1071,7 +1071,7 @@ void main() {
10711071
check(pushedRoutes.single).isA<DialogRoute<void>>();
10721072
await tester.tap(find.byWidget(checkErrorDialog(tester,
10731073
expectedTitle: zulipLocalizations.errorNotificationOpenTitle,
1074-
expectedMessage: zulipLocalizations.errorNotificationOpenAccountMissing)));
1074+
expectedMessage: zulipLocalizations.errorNotificationOpenAccountLoggedOut)));
10751075
});
10761076

10771077
testWidgets('find account among several', (tester) async {

0 commit comments

Comments
 (0)