Skip to content

Commit f0c1db7

Browse files
committed
ui [nfc]: Comment on some ways we can follow new Figma but haven't yet
I don't expect these to be fundamentally hard, they're just not really trivial; we'll leave them for later.
1 parent 1d8c599 commit f0c1db7

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

lib/widgets/theme.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ ThemeData zulipThemeData(BuildContext context) {
1616
scrolledUnderElevation: 0,
1717
backgroundColor: const Color(0xfff5f5f5), // `bg-top-bar` in Figma
1818

19+
// TODO match layout to Figma
1920
actionsIconTheme: const IconThemeData(
2021
color: Color(0xff666699), // `icon` in Figma
2122
),
@@ -35,6 +36,10 @@ ThemeData zulipThemeData(BuildContext context) {
3536
.merge(weightVariableTextStyle(context, wght: 600)),
3637
titleSpacing: 4,
3738

39+
// TODO Figma has height 42; we should try `toolbarHeight: 42` and test
40+
// that it looks reasonable with different system text-size settings.
41+
// Also the back button will look too big and need adjusting.
42+
3843
shape: const Border(bottom: BorderSide(
3944
color: Color(0x33000000), // `border-bar` in Figma
4045
strokeAlign: BorderSide.strokeAlignInside, // (default restated for explicitness)

0 commit comments

Comments
 (0)