autocomplete: Introduce a field for sorted users

This field will be used to maintain a list of sorted users based on the
most relevant autocomplete criteria in the upcoming commits.

This commit also removes the retry logic for an in-progress query
computation as there is no longer the cause that would necessitate such
a retry.

Author: sm-sayedi

lib/model/autocomplete.dart

@@ -164,20 +164,35 @@ class AutocompleteViewManager {
 ///  * When the object will no longer be used, call [dispose] to free
 ///    resources on the [PerAccountStore].
 class MentionAutocompleteView extends ChangeNotifier {
-  MentionAutocompleteView._({required this.store, required this.narrow});
+  MentionAutocompleteView._({
+    required this.store,
+    required this.narrow,
+    required this.sortedUsers,
+  });
 
   factory MentionAutocompleteView.init({
     required PerAccountStore store,
     required Narrow narrow,
   }) {
-    final view = MentionAutocompleteView._(store: store, narrow: narrow);
+    final users = store.users.values.toList();
+    final sortedUsers = sortByRelevance(users: users);
+    final view = MentionAutocompleteView._(
+      store: store,
+      narrow: narrow,
+      sortedUsers: sortedUsers,
+    );
     store.autocompleteViewManager.registerMentionAutocomplete(view);
     return view;
   }
+  
+  static List<User> sortByRelevance({required List<User> users}) {
+    return users; // TODO(#228) sort for most relevant first
+  }
 
   @override
   void dispose() {
     store.autocompleteViewManager.unregisterMentionAutocomplete(this);
+    sortedUsers.clear();
     // We cancel in-progress computations by checking [hasListeners] between tasks.
     // After [super.dispose] is called, [hasListeners] returns false.
     // TODO test that logic (may involve detecting an unhandled Future rejection; how?)
@@ -186,6 +201,7 @@ class MentionAutocompleteView extends ChangeNotifier {
 
   final PerAccountStore store;
   final Narrow narrow;
+  final List<User> sortedUsers;
 
   MentionAutocompleteQuery? get query => _query;
   MentionAutocompleteQuery? _query;
@@ -209,17 +225,7 @@ class MentionAutocompleteView extends ChangeNotifier {
   List<MentionAutocompleteResult> _results = [];
 
   _startSearch(MentionAutocompleteQuery query) async {
-    List<MentionAutocompleteResult>? newResults;
-
-    while (true) {
-      try {
-        newResults = await _computeResults(query);
-        break;
-      } on ConcurrentModificationError {
-        // Retry
-        // TODO backoff?
-      }
-    }
+    final newResults = await _computeResults(query);
 
     if (newResults == null) {
       // Query was old; new search is in progress. Or, no listeners to notify.
@@ -232,9 +238,8 @@ class MentionAutocompleteView extends ChangeNotifier {
 
   Future<List<MentionAutocompleteResult>?> _computeResults(MentionAutocompleteQuery query) async {
     final List<MentionAutocompleteResult> results = [];
-    final Iterable<User> users = store.users.values;
 
-    final iterator = users.iterator;
+    final iterator = sortedUsers.iterator;
     bool isDone = false;
     while (!isDone) {
       // CPU perf: End this task; enqueue a new one for resuming this work
@@ -245,7 +250,7 @@ class MentionAutocompleteView extends ChangeNotifier {
       }
 
       for (int i = 0; i < 1000; i++) {
-        if (!iterator.moveNext()) { // Can throw ConcurrentModificationError
+        if (!iterator.moveNext()) {
           isDone = true;
           break;
         }
@@ -256,7 +261,7 @@ class MentionAutocompleteView extends ChangeNotifier {
         }
       }
     }
-    return results; // TODO(#228) sort for most relevant first
+    return results;
   }
 }
 

test/model/autocomplete_test.dart

@@ -274,37 +274,6 @@ void main() {
     }
   });
 
-  test('MentionAutocompleteView mutating store.users while in progress causes retry', () async {
-    const narrow = CombinedFeedNarrow();
-    final store = eg.store();
-    for (int i = 0; i < 1500; i++) {
-      await store.addUser(eg.user(userId: i, email: 'user$i@example.com', fullName: 'User $i'));
-    }
-    final view = MentionAutocompleteView.init(store: store, narrow: narrow);
-
-    bool done = false;
-    view.addListener(() { done = true; });
-    view.query = MentionAutocompleteQuery('User 10000');
-
-    await Future(() {});
-    check(done).isFalse();
-    await store.addUser(eg.user(userId: 10000, email: '[email protected]', fullName: 'User 10000'));
-    await Future(() {});
-    check(done).isFalse();
-    await Future(() {});
-    check(done).isTrue();
-    check(view.results).single
-      .isA<UserMentionAutocompleteResult>()
-      .userId.equals(10000);
-    // new result sticks; no "zombie" result from `store.users` pre-mutation
-    for (int i = 0; i < 10; i++) { // for good measure
-      await Future(() {});
-      check(view.results).single
-        .isA<UserMentionAutocompleteResult>()
-        .userId.equals(10000);
-    }
-  });
-
   group('MentionAutocompleteQuery.testUser', () {
     doCheck(String rawQuery, User user, bool expected) {
       final result = MentionAutocompleteQuery(rawQuery)