store: Call connection.close in PerAccountStore.dispose

This seems hygienic. It makes sense to explicitly clean up an old
HTTP client's resources when we've set up a new one, for the
dead-queue reload. (The dead-queue reload is currently the only path
where this dispose method is called.)

It will also make sense to clean up these resources when an account
is logged out. That's a feature we'll be implementing soon, with
PerAccountStore.dispose in that new path as well.

The "abort long-poll and close ApiConnection" TODO was on
UpdateMachine's dispose method, not PerAccountStore's. But since
PerAccountStore is what owns the connection, its dispose method
seemed like the more appropriate place to close the connection.

Author: chrisbobbe

lib/model/store.dart

@@ -464,6 +464,7 @@ class PerAccountStore extends ChangeNotifier with EmojiStore, ChannelStore, Mess
     _messages.dispose();
     typingStatus.dispose();
     updateMachine?.dispose();
+    connection.close();
     _disposed = true;
     super.dispose();
   }
@@ -978,7 +979,11 @@ class UpdateMachine {
   ///
   /// After this is called, the instance is not in a usable state
   /// and should be abandoned.
-  void dispose() { // TODO abort long-poll and close ApiConnection
+  ///
+  /// To abort polling mid-request, [store]'s [PerAccountStore.connection]
+  /// needs to be closed using [ApiConnection.close], which causes in-progress
+  /// requests to error. [PerAccountStore.dispose] does that.
+  void dispose() {
     assert(!_disposed);
     NotificationService.instance.token.removeListener(_registerNotificationToken);
     _disposed = true;