Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login: Interpret API errors for the user #105

Open
2 tasks
chrisbobbe opened this issue May 23, 2023 · 1 comment
Open
2 tasks

login: Interpret API errors for the user #105

chrisbobbe opened this issue May 23, 2023 · 1 comment
Labels
Milestone

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented May 23, 2023

Needs #37.

When the user enters a realm URL, then their username/password, we should give more specific feedback on failure than "Could not connect" and "Login failed", respectively.

We've written TODO comments for that in the code:

  • This TODO in error handling on our getServerSettings request:
            // TODO(#105) give more helpful feedback; see `fetchServerSettings`
            //   in zulip-mobile's src/message/fetchActions.js. Needs #37.
            showErrorDialog(context: context,
              title: 'Could not connect', message: 'Failed to connect to server:\n$url');
  • This TODO in our error handling on fetchApiKey:
            // TODO(#105) give more helpful feedback. Needs #37. The RN app is
            //   unhelpful here; we should at least recognize invalid auth errors, and
            //   errors for deactivated user or realm (see zulip-mobile#4571).
            showErrorDialog(context: context, title: 'Login failed');

This issue is for tracking those TODOs.

@gnprice
Copy link
Member

gnprice commented May 24, 2023

For cross-reference: the zulip-mobile issue linked in one of those comments is:

gnprice added a commit to gnprice/zulip-flutter that referenced this issue May 24, 2023
In particular, this means we'll show messages from the server like
"Your username or password is incorrect" or "Enter a valid email address."

Fixes-partly: zulip#105
gnprice added a commit to gnprice/zulip-flutter that referenced this issue May 25, 2023
In particular, this means we'll show messages from the server like
"Your username or password is incorrect" or "Enter a valid email address."

Fixes-partly: zulip#105
@gnprice gnprice added this to the Beta milestone May 27, 2023
@gnprice gnprice added a-login and removed m-beta labels May 27, 2023
@gnprice gnprice modified the milestones: Beta 1, Beta 2 Nov 8, 2023
@gnprice gnprice modified the milestones: Beta 2, Beta 3 Nov 22, 2023
@gnprice gnprice modified the milestones: B2: Summer 2024, Launch May 9, 2024
@gnprice gnprice modified the milestones: Launch, Post-launch Jul 31, 2024
@gnprice gnprice modified the milestones: M6: Post-launch, M7: Future Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants