-
Notifications
You must be signed in to change notification settings - Fork 306
For emoji autocomplete, match insensitively to diacritics #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As part of the same work, let's also handle the possibility that the emoji's name has an upper-case letter where the query has lower case. This one doesn't come up at all for Unicode emoji: all our names are in lower case. But again it might come up for custom emoji in some realms. |
When making the search "fuzzy" like this, ideally we'd prioritize non-fuzzy matches over fuzzy matches. (zulip/zulip#32634 gave me the idea to comment here; we can split this to a new issue if helpful.) |
Hello @gnprice , issue.1067.mp4 |
From the snippet in that demo, that looks like broadly the right sort of behavior. To tell whether it's an accurate solution would require more detail, like an implementation and its tests. This is a post-launch issue, though — in fact it's in the M7 Future milestone, beyond M6 Post-launch. So we won't be able to spend time giving feedback on PRs for it until after the app has been launched. |
To get clear idea of implementation I had created a PR. |
For emoji autocomplete, if the emoji's name has
é
where the user's query hase
or vice versa, we should treat that as a match. The semantics should match what the web app does.This doesn't much arise for Unicode emoji, because for all the (small number of) Unicode emoji where a name has a diacritic, we also give the emoji an alternate name by removing the diacritics. It might come up for custom emoji in some realms.
Related issues
The text was updated successfully, but these errors were encountered: