Skip to content

tryAnotherAccountMessage stops being center-aligned when text is long enough to wrap #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisbobbe opened this issue Jan 2, 2025 · 3 comments · Fixed by #1326
Closed

tryAnotherAccountMessage stops being center-aligned when text is long enough to wrap #1246

chrisbobbe opened this issue Jan 2, 2025 · 3 comments · Fixed by #1326
Assignees
@KYash03
Milestone
M5b: Launch goals

Comments

@chrisbobbe
Copy link
Collaborator

One line (centered) Two lines (not centered)
image image

Probably the Text widget itself is getting centered, but we're not configuring the Text itself to center its content, which I think we'd do with a TextAlign.center.

It looks like it's been this way since the text was introduced, in a97ac42. Assigning @PIG208, the author of that commit. 🙂
@KYash03
Copy link
Contributor

KYash03 commented Feb 4, 2025

Hello, is anyone currently working on this issue? If not, I'd like to claim it and start working on it. Thanks!

@chrisbobbe chrisbobbe assigned KYash03 and unassigned PIG208 Feb 4, 2025
@chrisbobbe
Copy link
Collaborator Author

Sure; I've just assigned you.

@KYash03 KYash03 mentioned this issue Feb 5, 2025
Merged
@KYash03
Copy link
Contributor

KYash03 commented Feb 5, 2025 •
edited
Loading

Please review #1326. Thanks!

@chrisbobbe chrisbobbe added this to the M5: Launch milestone Feb 5, 2025
KYash03 added a commit to KYash03/zulip-flutter that referenced this issue Feb 5, 2025
@KYash03
home: Center align the "try another account" message in loading place…
f217e16 
…holder

Fixes zulip#1246
KYash03 added a commit to KYash03/zulip-flutter that referenced this issue Feb 6, 2025
@KYash03
home: Center align the "try another account" message in loading place…
dc49661 
…holder

Fixes zulip#1246
KYash03 added a commit to KYash03/zulip-flutter that referenced this issue Feb 7, 2025
@KYash03
home: Center align the "try another account" message in loading place…
21e496b 
…holder

Fixes zulip#1246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KYash03 KYash03

Labels
None yet
Projects
Flutter app
Status: Done
Milestone
M5b: Launch goals
Development

Successfully merging a pull request may close this issue.

home: Center align the "try another account" message in loading placeholder KYash03/zulip-flutter
3 participants
@chrisbobbe @PIG208 @KYash03