Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Navigation Bar Color Doesn't Update on Theme Change #1333

Open
Gaurav-Kushwaha-1225 opened this issue Feb 6, 2025 · 2 comments
Open
Labels
a-Android Issues specific to Android, or requiring Android-specific work a-design Visual and UX design upstream Would benefit from work in Flutter or another upstream

Comments

@Gaurav-Kushwaha-1225
Copy link
Contributor

Summary:

When changing the theme after opening the app, the system navigation bar color does not update accordingly. The expected behavior is for the navigation bar to match the theme's background color, but it retains the previous theme's color. Reopening the after closing doesn't reproduce this issue.

Steps to reproduce:

  • Open the Zulip Flutter app.
  • Change the theme (e.g., from light to dark or vice versa).
  • Observe the system navigation bar color at the bottom of the screen.

Device and environment:

  • Device: CPH2381
  • OS version: 14
  • Zulip app version: Latest Commit when creating this issue ca26330
  • Build variant: Debug

Screenshots:

  • Opened app in dark theme but after changing theme to light.
Image Image
  • Opened app in light theme but after changing theme to dark.
Image Image

Possible solution (if applicable):

  • The issue might be related to SystemChrome.setSystemUIOverlayStyle, which may not be getting updated when the theme changes. Ensuring this function is called whenever the theme is switched could fix the problem.
@gnprice gnprice added this to the M6: Post-launch milestone Feb 6, 2025
@gnprice gnprice added a-Android Issues specific to Android, or requiring Android-specific work a-design Visual and UX design upstream Would benefit from work in Flutter or another upstream labels Feb 6, 2025
@gnprice
Copy link
Member

gnprice commented Feb 6, 2025

Thanks for the report!

I believe this is specific to Android 14 and below (and possibly non-default configurations on Android 15+) — that bar doesn't exist on Android 15, at least by default, because of edge-to-edge mode.

Marked as post-launch because although this is pretty unsightly when it happens, I think this situation is pretty uncommon for users who aren't developing the app.

@Vedanshi27vishu

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-Android Issues specific to Android, or requiring Android-specific work a-design Visual and UX design upstream Would benefit from work in Flutter or another upstream
Projects
Status: No status
Development

No branches or pull requests

3 participants