Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When no account is active, ensure that the root level route is always choose-account page #1369

Open
PIG208 opened this issue Feb 21, 2025 · 3 comments
Labels
a-api Implementing specific parts of the Zulip server API

Comments

@PIG208
Copy link
Member

PIG208 commented Feb 21, 2025

This can happen if the account is logged out on a non-AccountRoute route. Normally this would be a page reachable from logged in account, such as "About Zulip" page.

When that happens, routes to be removed on logged out are removed, leaving only the "About Zulip" page on the navigator stack. Since the navigator stack is non-empty, the choose-account page route is not pushed onto the stack. The symptom is that the user can no longer log into another account.

Assigned a higher priority because this bug is relatively easy to reproduce:

  • From the home page, navigate to "About Zulip" through the main-menu bottom sheet
  • Invalidate the account's API key on web

Related:

@PIG208 PIG208 added the a-api Implementing specific parts of the Zulip server API label Feb 21, 2025
@PIG208 PIG208 modified the milestones: M5-a: Server 10, M5: Launch Feb 21, 2025
@gnprice
Copy link
Member

gnprice commented Feb 21, 2025

Thanks. Can you spell out a specific repro recipe? It sounds like you have one but I'm not quite picking out what it is.

@gnprice
Copy link
Member

gnprice commented Feb 21, 2025

I see, it looks like you've edited the description to add a repro recipe, thanks.

That recipe makes it straightforward to repro when one is trying, but I think this is a scenario that's going to be quite uncommon in practice. So I don't think this needs to be something that holds up the launch.

@gnprice gnprice modified the milestones: M5: Launch, M6: Post-launch Feb 21, 2025
@vivekTiw120303

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API
Projects
Status: No status
Development

No branches or pull requests

3 participants