Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use last_moved_timestamp instead of scanning edit_history #1397

Open
gnprice opened this issue Mar 11, 2025 · 0 comments
Open

Use last_moved_timestamp instead of scanning edit_history #1397

gnprice opened this issue Mar 11, 2025 · 0 comments
Labels
a-api Implementing specific parts of the Zulip server API server-10 Things new in Zulip Server 10.0

Comments

@gnprice
Copy link
Member

gnprice commented Mar 11, 2025

The server will be introducing (probably in Zulip Server 10) a field last_moved_timestamp on message objects, as well as narrowing the meaning of last_edit_timestamp. Together these are intended to let the client skip scanning through edit_history to determine whether a message has been edited or moved.

We should start interpreting the new fields when present, instead of doing that scanning. This will be more efficient, and also a step toward the server being able to stop sending the full edit history in the future.

Implementation

On old servers, we'll continue scanning edit_history. Let's have that logic express its conclusion in the form of the same last_moved_timestamp and last_edit_timestamp information that new servers send.

Then the rest of the app can effectively use the new API, looking at those two fields, without caring about the existence of the old API.

References

@gnprice gnprice added a-api Implementing specific parts of the Zulip server API server-10 Things new in Zulip Server 10.0 labels Mar 11, 2025
@gnprice gnprice added this to the M5: Launch milestone Mar 11, 2025
@gnprice gnprice modified the milestones: M5: Launch, M6: Post-launch Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API server-10 Things new in Zulip Server 10.0
Projects
Status: No status
Development

No branches or pull requests

1 participant