Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Follow user_settings.twenty_four_hour_time #1015

Open
chrisbobbe opened this issue Oct 21, 2024 · 3 comments · May be fixed by #1398
Open

ui: Follow user_settings.twenty_four_hour_time #1015

chrisbobbe opened this issue Oct 21, 2024 · 3 comments · May be fixed by #1398
Assignees
@Gaurav-Kushwaha-1225
Milestone
M6: Post-launch

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Oct 21, 2024 •
edited
Loading

When we show timestamps, for example on messages in the message list, we should format them according to the user's setting:

  • user_settings.twenty_four_hour_time true: "13:52"
  • user_settings.twenty_four_hour_time false: "1:52 PM"

See:

  • Help center doc
  • UserSettings.twentyFourHourTime in lib/api/model/initial_snapshot.dart
  • UserSettingsUpdateEvent in lib/api/model/events.dart

Milestoning as "Launch" because I believe we do this in zulip-mobile.
@chrisbobbe chrisbobbe added this to the Launch milestone Oct 21, 2024
@chrisbobbe chrisbobbe mentioned this issue Oct 21, 2024
Closed
@c-o-d-e-y-o-d-a
Copy link

I would like to work on this issue if it has not been assigned to anyone else.

@chrisbobbe
Copy link
Collaborator Author

Please see the Zulip project's guide to claiming an issue: https://zulip.readthedocs.io/en/latest/contributing/contributing.html#in-other-zulip-repositories

In particular:

In your comment, describe what part of the code you’re modifying and how you plan to approach the problem, based on what you learned in steps 1–4 above.

@gnprice gnprice modified the milestones: Launch, Post-launch Nov 21, 2024
@Gaurav-Kushwaha-1225
Copy link
Contributor

Gaurav-Kushwaha-1225 commented Mar 11, 2025 •
edited
Loading

Hi @chrisbobbe,

I would like to take up this issue.

I have started working on it and have achieved some successful results.
You can review my changes here: Compare Changes.
Please permit me to continue working on this issue.

Additionally, I have taken screenshots after changing the twenty_four_hour_time preference in my account via the web app:

12-Hour Format 24-Hour Format
12-Hour 24-Hour

Currently, some checks are failing. I will look into them once the issue is assigned to me.

Looking forward to your feedback! 🚀

@Gaurav-Kushwaha-1225 Gaurav-Kushwaha-1225 linked a pull request Mar 11, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gaurav-Kushwaha-1225 Gaurav-Kushwaha-1225

Labels
None yet
Projects
Flutter app
Status: No status
Milestone
M6: Post-launch
Development

Successfully merging a pull request may close this issue.

msglist: Follow user settings for message timestamps Gaurav-Kushwaha-1225/zulip-flutter
4 participants
@gnprice @chrisbobbe @c-o-d-e-y-o-d-a @Gaurav-Kushwaha-1225