Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List of topics in channel #1158

Open
gnprice opened this issue Dec 13, 2024 · 13 comments · May be fixed by #1449
Open

List of topics in channel #1158

gnprice opened this issue Dec 13, 2024 · 13 comments · May be fixed by #1449
Assignees
@lakshya1goel
Labels
a-design Visual and UX design beta feedback Things beta users have specifically asked for
Milestone
M5a: Launch blockers

Comments

@gnprice
Copy link
Member

gnprice commented Dec 13, 2024 •
edited
Loading

In the legacy app, if you're looking at the messages in a topic, we have a button in the app bar (a "list" icon) that gets you a list of all the topics in that channel. It's sorted by recency, and shows the number of unreads, whether you have an @-mention, and whether the topic is muted etc.

Basically it's similar to what you get in the web left sidebar after hitting "Show all topics" under a given channel.

We should offer the same thing in the new app. I wasn't sure people really use that feature; but it came up in user feedback after yesterday's beta announcement, so that's a sign that people do.

Design

Design is in Figma:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=6819-35869&m=dev

Image

For this issue, differences from the design there:

  • The design shows a "pinned topics" feature, which is a possible future Zulip feature but doesn't currently exist. Pending that feature, we'll leave out the "pinned" icon, and avoid using up horizontal space for it.
  • For this first version, let's leave out the "filter" feature. I'll file a post-launch followup issue for that. → Filter topics in topic-list screen #1384
  • For this issue, we'll leave out the "New topic" button and the modal it leads to. I'll file a separate, post-launch issue for that. → "New topic" modal from list of topics in channel #1385

Implementation

The list of topics will come from making a request to the server, after opening the page.

As a follow-up task, after getting the list for a given channel we might store it (on ChannelStore), and keep it up to date when handling events, so that coming back a second time to this topic-list page for a given channel is fast. For this PR, though, that's out of scope. Instead the list of topics can just live on a StatefulWidget for the page.

References
@gnprice gnprice added the beta feedback Things beta users have specifically asked for label Dec 13, 2024
@gnprice gnprice added this to the M6: Post-launch milestone Dec 13, 2024
@gnprice gnprice mentioned this issue Dec 14, 2024
Open
@gnprice gnprice modified the milestones: M6: Post-launch, M5: Launch Dec 18, 2024
@PIG208 PIG208 assigned PIG208 and unassigned PIG208 Dec 23, 2024
@chrisbobbe
Copy link
Collaborator

Tim and others propose featuring this page more prominently than the interleaved channel view:

Tim said:

I've never been happy with the legacy app's approach of having the channel feed be what clicking on a channel takes you to by default. We've been moving towards it being a secondary action on channels in the web app, and I think it'd be wise to just make the default click be the list of topics, and channel feed be the thing that's a smaller tap target button.

@chrisbobbe
Copy link
Collaborator

And another long-time Zulip user said:

In the old app, opening a channel from the channel view shows a feed of all the messages in the channel, but it has a button in the upper right that looks like a list, which opens a view of all topics with a single line for each topic.

In the new app, there doesn't seem to be any way to show all the topics in a channel without showing the messages within those topics.

(In an ideal world, that would be the default view I get when opening a channel.)

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Dec 27, 2024 •
edited by gnprice
Loading

Another user said:

[…] it feels unnatural to always browse all messages in all topics. Topics can be really long like folks talking about Haiku operating system.

And browsing all of them to cherry pick something is also a pain.

@chrisbobbe chrisbobbe added the a-design Visual and UX design label Dec 27, 2024
@gnprice gnprice modified the milestones: M5: Launch, M5-a: Server 10 Jan 14, 2025
@chrisbobbe
Copy link
Collaborator

From a review in the Google Play Console:

It is nice, but the absence of a search bar (at least to search for topics) makes it frustrating to use.

I assume we'll want this list of topics to be searchable, like in zulip-mobile.

@MazenMustafa1

This comment has been minimized.

Sign in to view
@chrisbobbe

This comment has been minimized.

Sign in to view
@MazenMustafa1

This comment has been minimized.

Sign in to view
@chrisbobbe

This comment has been minimized.

Sign in to view
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 26, 2025
@E-m-i-n-e-n-c-e
i18n: Add topic list strings to all localizations.
908a0a3 
Add "Show topics" button tooltip and "Search topics" placeholder text
to all language files (English, Slovak, Norwegian, Polish, Russian,
Arabic, and Japanese).

Fixes part of zulip#1158.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 26, 2025
@E-m-i-n-e-n-c-e
msglist: Add topic list page
a0c9f2f 
This commit creates a new topic list page showing all topics in
current channel with search functionality ordered by recency

Fixes part of zulip#1158.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 26, 2025
@E-m-i-n-e-n-c-e
msglist: Add topic list page
f75e83b 
This commit creates a new topic list page showing all topics in
current channel with search functionality ordered by recency

Fixes part of zulip#1158.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 26, 2025
@E-m-i-n-e-n-c-e
msglist: Add topic list button to app bar
0100430 
Add topic list button to app bar actions in message list view. The button
appears in channel narrows and navigates to the topic list page when
pressed. Uses the topic icon and localized tooltip.

Fixes zulip#1158.
@E-m-i-n-e-n-c-e E-m-i-n-e-n-c-e mentioned this issue Feb 26, 2025
Closed
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 26, 2025
@E-m-i-n-e-n-c-e
msglist: Add topic list page
40ed9b2 
This commit creates a new topic list page showing all topics in
current channel with search functionality ordered by recency

Fixes part of zulip#1158.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 26, 2025
@E-m-i-n-e-n-c-e
msglist: Add topic list button to app bar
267f8e1 
Add topic list button to app bar actions in message list view. The button
appears in channel narrows and navigates to the topic list page when
pressed. Uses the topic icon and localized tooltip.

Fixes zulip#1158.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 26, 2025
@E-m-i-n-e-n-c-e
msglist: Add topic list page
6aa6995 
This commit creates a new topic list page showing all topics in
current channel with search functionality ordered by recency

Also adds a button to app bar actions in message list page which
appears in channel narrows and navigates to the topic list page
when pressed

Fixes zulip#1158.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 26, 2025
@E-m-i-n-e-n-c-e
msglist: Add topic list page
c3e4e36 
This commit creates a new topic list page showing all topics in
current channel with search functionality ordered by recency

Also adds a button to app bar actions in message list page which
appears in channel narrows and navigates to the topic list page
when pressed

Fixes zulip#1158.
@gnprice
Copy link
Member Author

gnprice commented Feb 28, 2025

@lakshya1goel plans to implement this feature; see #mobile-design > Topic list in channel @ 💬.

@gnprice
Copy link
Member Author

gnprice commented Mar 6, 2025

We now have a design for this feature; I've updated the issue description with details.

@gnprice gnprice mentioned this issue Mar 6, 2025
Open
@MazenMustafa1

This comment has been minimized.

Sign in to view
@PIG208

This comment has been minimized.

Sign in to view
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Mar 29, 2025
@lakshya1goel
topicList: Add topic list page for each channel
c317fbe 
fixes: zulip#1158
@lakshya1goel lakshya1goel linked a pull request Mar 29, 2025 that will close this issue
Open
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Mar 29, 2025
@lakshya1goel
topicList: Add topic list page for each channel
3ccccf3 
fixes: zulip#1158
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Mar 29, 2025
@lakshya1goel
topicList: Add topic list page for each channel
dfc6f79 
fixes: zulip#1158
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Mar 30, 2025
@lakshya1goel
topicList: Add topic list page for each channel
6f6e5b6 
fixes: zulip#1158
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Mar 30, 2025
@lakshya1goel
topicList: Add topic list page for each channel
5dea5f1 
fixes: zulip#1158
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Mar 30, 2025
@lakshya1goel
topicList: Add topic list page for each channel
5a7871f 
fixes: zulip#1158
@lakshya1goel
Copy link
Contributor

Hi, PR #1449 is ready for review, PTAL. Thanks!

lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Apr 2, 2025
@lakshya1goel
topicList: Add topic list page for each channel
504056a 
fixes: zulip#1158
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Apr 8, 2025
@lakshya1goel
topicList: Add topic list page for each channel
4d29e1a 
fixes: zulip#1158
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Apr 9, 2025
@lakshya1goel
topicList: Add topic list page for each channel
771f58c 
fixes: zulip#1158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lakshya1goel lakshya1goel

Labels
a-design Visual and UX design beta feedback Things beta users have specifically asked for
Projects
Flutter app
Status: No status
Milestone
M5a: Launch blockers
5 participants
@gnprice @chrisbobbe @PIG208 @MazenMustafa1 @lakshya1goel