-
Notifications
You must be signed in to change notification settings - Fork 306
Handle updated streams (stream op: update
events)
#182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm not sure how best to represent the type of this event; see in the doc, for example, |
(Handling `op: update` events is zulip#182, as mentioned in the TODOs.)
Ah: removing this from the "beta" milestone until we make that choice explicitly for this event type. From Greg's comment on the umbrella issue #135 (comment) :
|
(Handling `op: update` events is zulip#182, as mentioned in the TODOs.)
(Handling `op: update` events is zulip#182, as mentioned in the TODOs.)
The properties of Subscription are a superset of ZulipStream properties. Unfortunately this means there are duplicate fields (such as the stream name) that live in two places and there is no mechanism yet to synchronize them (that is work left for zulip#182). This change makes is clearer which properties of Subscription are specific to subscriptions.
The properties of Subscription are a superset of ZulipStream properties. Unfortunately this means there are duplicate fields (such as the stream name) that live in two places and there is no mechanism yet to synchronize them (that is work left for zulip#182). This change makes is clearer which properties of Subscription are specific to subscriptions.
Update: a couple of months after this comment, we added To see all the different pieces of that pattern, see commits 9cb2e4d and 4bcbffd (both from #261). I think a good PR for this issue will look a lot like those two commits. |
I am going to assign this to myself as it is needed for #674. |
Part of #135.
https://zulip.com/api/get-events#stream-update
Handling created/deleted streams (
stream op: create
/stream op: delete
) is #181.I expect this will involve updating both our
store.streams
andstore.subscriptions
data structures.The text was updated successfully, but these errors were encountered: