Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offer a list of all channels, and a way to subscribe #188

Open
gnprice opened this issue Jun 14, 2023 · 3 comments · May be fixed by #832
Open

Offer a list of all channels, and a way to subscribe #188

gnprice opened this issue Jun 14, 2023 · 3 comments · May be fixed by #832
Assignees
@Khader-1
Labels
a-home The home screens of the app; finding and starting conversations
Milestone
M6: Post-launch

Comments

@gnprice
Copy link
Member

gnprice commented Jun 14, 2023 •
edited
Loading

Sometimes one wants to navigate to a channel/stream when not already subscribed, or to subscribe to a channel.

Like in zulip-mobile, we'll offer this functionality as an "All channels" screen, reached from a button at the bottom of the "Channels" tab.

Design

This screen has a design in Figma:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=7723-6411&m=dev

Image

See there for details, including some notes.

Differences from Figma:

  • The design there shows a "New channel" button. That is a useful feature but will be a separate follow-up issue.
  • The design there shows a "Filter channels" search box at the top. That is a useful feature but will be a separate follow-up issue.
  • The design there shows a modified channel action sheet.
    • The action sheet, and the "..." button leading to it, are required as part of this issue. (The action sheet provides the way to navigate from this screen to a channel.)
    • The extra details at the top of the action sheet — channel icon, name, description, and statistics — will be a separate issue.
@gnprice gnprice added the a-home The home screens of the app; finding and starting conversations label Jun 14, 2023
@gnprice gnprice added this to the Launch milestone Jun 14, 2023
@gnprice gnprice mentioned this issue Jun 14, 2023
Closed
gnprice added a commit that referenced this issue Jun 14, 2023
@gnprice
doc: Convert remaining TODOs from readme into GitHub issues
04deea2 
Filed #187, #188, and #190.

Other items already existed as #80, #82, #95, #122, and #123,
or were already complete (a compose box, and three ways of
attaching something to a message.)
@opxdelwin
Copy link

Hey @gnprice I'd like to work on this issue. I'd love some help regarding the UI implementation.

  • Should we show both subscribed and unsubscribed streams?

@gnprice
Copy link
Member Author

gnprice commented Mar 19, 2024

Yes indeed — this screen should show all streams. (Well, all streams that the user is able to see.)

Cross-referencing, we have a more detailed discussion in this chat thread:
https://chat.zulip.org/#narrow/stream/48-mobile/topic/all-streams.20screen.20.23F188/near/1761243

@gnprice gnprice modified the milestones: Launch, B2: Summer 2024 May 9, 2024
@Khader-1 Khader-1 self-assigned this Jul 18, 2024
@Khader-1 Khader-1 linked a pull request Jul 23, 2024 that will close this issue
Draft
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 27, 2024
@Khader-1
channel_list: Setup "All Channels" page
726e2e3 
Fixes: zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 29, 2024
@Khader-1
channel_list: Setup "All Channels" page
e367c16 
Fixes parts of zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 29, 2024
@Khader-1
channel_list: Implement Subscribe to channel
3567ebb 
Fixes: zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 29, 2024
@Khader-1
channel_list: Setup "All Channels" page
88540cc 
Fixes parts of zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Jul 29, 2024
@Khader-1
channel_list: Implement Subscribe to channel
2657df5 
Fixes: zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 7, 2024
@Khader-1
channel_list: Setup "All Channels" page
ea790b7 
Fixes parts of zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 7, 2024
@Khader-1
channel_list: Implement Subscribe to channel
3e68b33 
Fixes: zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 8, 2024
@Khader-1
channel_list: Setup "All channels" page
b750330 
Fixes parts of zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 8, 2024
@Khader-1
channel_list: Implement Subscribe to channel
ef00241 
Fixes: zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 12, 2024
@Khader-1
channel_list: Setup "All channels" page
71199d6 
Fixes parts of zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 12, 2024
@Khader-1
channel_list: Implement Subscribe to channel
8d5460a 
Fixes: zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 22, 2024
@Khader-1
channel_list: Create "All channels" page
215ae7f 
This creates the page that contains all channels list, still we need
to implement subscribe/unsubscribe logic which will be introduced in
the upcoming commits.

Fixes parts of zulip#188

channel_list: Show a label when no channels are found

channel_list: Order channels alphabetically
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 22, 2024
@Khader-1
channel_list: Implement subscribe to channel
bf383fe 
Fixes: zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 22, 2024
@Khader-1
channel_list: Create "All channels" page
494e969 
This creates the page that contains all channels list, still we need
to implement subscribe/unsubscribe logic which will be introduced in
the upcoming commits.

Fixes parts of zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 22, 2024
@Khader-1
channel_list: Implement subscribe to channel
e37f8b4 
Fixes: zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 29, 2024
@Khader-1
channel_list: Create "All channels" page
4e8df19 
This creates the page that contains all channels list, still we need
to implement subscribe/unsubscribe logic which will be introduced in
the upcoming commits.

Fixes parts of zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 29, 2024
@Khader-1
channel_list: Implement subscribe to channel
b75ddf8 
Fixes: zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Aug 29, 2024
@Khader-1
channel_list: Implement subscribe to channel
296a844 
Fixes: zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Nov 19, 2024
@Khader-1
channel_list: Create "All channels" page
f51e828 
This creates the page that contains all channels list, still we need
to implement subscribe/unsubscribe logic which will be introduced in
the upcoming commits.

Fixes parts of zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Nov 19, 2024
@Khader-1
channel_list: Implement subscribe to channel
1f30bba 
Fixes: zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Nov 19, 2024
@Khader-1
channel_list: Implement subscribe to channel
88417ac 
Fixes: zulip#188
Khader-1 added a commit to Khader-1/zulip-flutter that referenced this issue Nov 19, 2024
@Khader-1
channel_list: Implement subscribe to channel
793e9bf 
Fixes: zulip#188
@gnprice gnprice modified the milestones: Beta 3: Summer 2024, Launch Nov 21, 2024
@gnprice gnprice mentioned this issue Dec 16, 2024
Open
@gnprice gnprice modified the milestones: M5: Launch, M6: Post-launch Dec 18, 2024
@gnprice gnprice changed the title Offer a list of all streams, and a way to subscribe Offer a list of all channels, and a way to subscribe Dec 18, 2024
@gnprice gnprice mentioned this issue Dec 23, 2024
Closed
@gnprice
Copy link
Member Author

gnprice commented Mar 12, 2025

This feature now has a design in Figma (thanks Vlad!). I've updated the description to reflect that.

@gnprice gnprice mentioned this issue Mar 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Khader-1 Khader-1

Labels
a-home The home screens of the app; finding and starting conversations
Projects
Flutter app
Status: No status
Milestone
M6: Post-launch
Development

Successfully merging a pull request may close this issue.

channel_list: All channels screen Khader-1/zulip-flutter
3 participants
@gnprice @Khader-1 @opxdelwin