Skip to content

msglist: Offer search narrows #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnprice opened this issue Aug 3, 2023 · 4 comments
Open

msglist: Offer search narrows #252

gnprice opened this issue Aug 3, 2023 · 4 comments
Labels
a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for

Comments

@gnprice
Copy link
Member

gnprice commented Aug 3, 2023

This is a bit more complex than other narrows (#72, #250, #251) for a couple of reasons:

  • It calls for some UI of its own, for the user to enter the search they want.
  • The messages themselves should have a bit more data, to highlight the text within them that matched the query. This comes from the server as match_content and match_subject fields on the message objects; see https://zulip.com/api/get-messages .

For a first version, the search UI can be at the same level as in zulip-mobile, which means fairly crude: it doesn't support anything more than a text search. Ideally we'd support the richer range of searches that Zulip supports in general, complete with UI for the various kinds of filters, but that can be a followup issue.

The UI also calls for some care with concurrency and asynchronicity. See zulip-mobile's implementation.

@gnprice gnprice added the a-msglist The message-list screen, except what's label:a-content label Aug 3, 2023
@gnprice gnprice added this to the Launch milestone Sep 14, 2023
@chrisbobbe
Copy link
Collaborator

Probably as a followup, we should make it easy to search shared history in addition to searching personal history. The zulip-flutter equivalent of zulip/zulip-mobile#5732.

@gnprice gnprice modified the milestones: Launch, Post-launch Jul 31, 2024
@gnprice gnprice added the beta feedback Things beta users have specifically asked for label Dec 26, 2024
@gnprice
Copy link
Member Author

gnprice commented Dec 26, 2024

A user writes last week:

I don't use search that often, and mostly on Desktop, but when I do use it I really do need it. So I really wish it will continue to be available in the future, even if it's not working perfectly.

@chrisbobbe
Copy link
Collaborator

From a review in the Google Play Console:

It is nice, but the absence of a search bar (at least to search for topics) makes it frustrating to use.

@chrisbobbe
Copy link
Collaborator

This came up in beta feedback: #mobile > Flutter Beta: Some Feedback @ 💬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for
Projects
Status: No status
Development

No branches or pull requests

2 participants