Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightbox: Animate entrance/exit of the lightbox's top and bottom app bars #38

Open
chrisbobbe opened this issue Mar 31, 2023 · 1 comment
Labels
a-lightbox The lightbox / image-viewer screen

Comments

@chrisbobbe
Copy link
Collaborator

Currently the lightbox's top and bottom app bars respond to touch by appearing and disappearing. Currently they just abruptly appear and disappear, but they should nice entrance/exit animations. The React Native app has them slide in and out; we could do that or perhaps a fading animation.

@gnprice gnprice added the a-lightbox The lightbox / image-viewer screen label May 27, 2023
@gnprice gnprice added this to the Launch milestone Jun 15, 2023
@chrisbobbe
Copy link
Collaborator Author

Mentioning here, since it came up in #224 (review):

  • This needs to work on devices where the OS intrudes on the app's space at the top and bottom of the screen (like the iPhone "notch" for the camera etc.).
  • The layout should look reasonable even when the user changes their preferred text size in their device's accessibility settings.

@gnprice gnprice modified the milestones: Launch, Post-launch May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-lightbox The lightbox / image-viewer screen
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants